-
Notifications
You must be signed in to change notification settings - Fork 0
release: 2.9.0 #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 2.9.0 #79
Conversation
🧪 Testing To try out this version of the SDK, run:
Expires: Thu, 25 Sep 2025 00:28:43 GMT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 968a018 in 1 minute and 54 seconds. Click for details.
- Reviewed
144
lines of code in8
files - Skipped
0
files when reviewing. - Skipped posting
8
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .release-please-manifest.json:1
- Draft comment:
Version bumped to 2.9.0. Confirm that this aligns with your intended release. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is asking the PR author to confirm their intention regarding a version bump, which violates the rule against asking for confirmation of intention. It does not provide a specific code suggestion or highlight a potential issue with the code itself.
2. .stats.yml:1
- Draft comment:
The openapi_spec_url and its hash have been updated. Verify that these match the new spec version. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to verify that the openapi_spec_url and its hash match the new spec version. This falls under asking the author to double-check things, which is not allowed according to the rules.
3. CHANGELOG.md:3
- Draft comment:
Changelog updated for version 2.9.0 with the documented docs update. Ensure any changes (e.g. renaming of parameters) are mentioned in the release notes if needed. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is asking the PR author to ensure that changes are mentioned in the release notes, which falls under the rule of not asking the author to ensure or verify things. It doesn't provide a specific code suggestion or point out a specific issue with the code.
4. pyproject.toml:3
- Draft comment:
Version in pyproject.toml is updated to 2.9.0. Looks correct. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is purely informative and does not provide any actionable feedback or suggestions. It simply states that the version update looks correct, which is not useful for the PR author.
5. src/openint/_client.py:1420
- Draft comment:
The 'list_events' method now uses 'include_prompt' (bool) instead of the earlier 'expand' parameter. Consider adding a brief docstring note on what 'include_prompt' controls for clarity in the public API. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. src/openint/_version.py:1
- Draft comment:
The version in _version.py is updated to 2.9.0, which is consistent with the rest of the release. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is purely informative, as it only states that the version number is consistent with the rest of the release. It doesn't provide any actionable feedback or suggestions for improvement.
7. src/openint/types/client_list_events_params.py:9
- Draft comment:
The TypedDict now defines 'include_prompt' as a bool. It may help to add an inline comment describing what effect setting this flag has. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% Since this is an auto-generated file (from OpenAPI spec), suggesting manual edits to the file is likely not useful as they would be overwritten on the next generation. The proper fix would be to update the OpenAPI spec instead. Additionally, the meaning of include_prompt is fairly self-explanatory from the parameter name. The comment does point out an inconsistency in documentation style within the file. Maybe there's a bug in the OpenAPI spec generation that should be fixed? While documentation inconsistency might be worth addressing, it should be fixed in the OpenAPI spec or generator, not by manually editing the generated file. Making manual edits to generated files is an anti-pattern. The comment should be deleted because it suggests manually modifying an auto-generated file, which would be overwritten. Any documentation improvements should be made in the OpenAPI spec instead.
8. tests/api_resources/test_client.py:686
- Draft comment:
Tests for list_events have been updated to use include_prompt (e.g. include_prompt=True). Confirm that all tests now correctly reflect the API change. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to confirm that all tests reflect the API change, which is against the rules. It doesn't provide a specific suggestion or point out a specific issue with the code.
Workflow ID: wflow_F4Zjspw0YgaI2yIC
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
968a018
to
649c693
Compare
649c693
to
dd7fc08
Compare
dd7fc08
to
3efa0ff
Compare
3efa0ff
to
998dc4e
Compare
Automated Release PR
2.9.0 (2025-08-26)
Full Changelog: v2.8.0...v2.9.0
Features
Chores
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions