Skip to content

Conversation

MikeBirdTech
Copy link
Contributor

Describe the changes you have made:

Instead of self.__init__() where all parameters are cleared, now self.messages =[] is ran, which will clear all the messages of the conversation but will preserve the parameters, such as api_base, api_key, and more.

Outstanding question

This does not clear the conversation history when conversation_history=True. That can be added easily. Is that expected behaviour?

Reference any relevant issues (e.g. "Fixes #000"):

#1090

Pre-Submission Checklist (optional but appreciated):

  • I have included relevant documentation updates (stored in /docs)
  • I have read docs/CONTRIBUTING.md
  • I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux

@MikeBirdTech MikeBirdTech changed the base branch from development to main March 19, 2024 00:41
@MikeBirdTech
Copy link
Contributor Author

I wanted to highlight the outstanding question

This does not clear the conversation history when conversation_history=True. That can be added easily. Is that expected behaviour?

@KillianLucas KillianLucas merged commit f11f1e2 into openinterpreter:main Mar 19, 2024
@KillianLucas
Copy link
Collaborator

Great work Mike! I think it's fine that it doesn't clear the history—it's more like opening a new chat. Let me know if you feel the other way. Merged!

@MikeBirdTech MikeBirdTech deleted the fix-reset branch August 3, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants