-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Support OpenAI's new models. #1099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here's the reference Models - OpenAI API. |
I don't use other LLMs much, so my commit only focus on OpenAI GPTs. If anyone familiar with other models and their proper context window and max tokens configs, please add configs like this commit to make OI support more models by default. |
My bad, haven't seen there's already one #1069 |
There is probably a better way to do this. I'll take a look later today. |
Just a note, for the vision models, function calling has to be False or they break. |
Maybe we can simply use |
Strongly recommend to try |
Exactly this. In OpenAI's January blog post, they stated that 70% of their customers had transitioned to gpt-4-turbo from gpt-4. |
@KillianLucas If you are going to merge this, just squeeze my commits. Nobody wants 3 lines changed in 4 commits. >_< |
Nice @Steve235lab, makes the most of these models without needing to set specific settings. Will do another test run soon (and set up some more robust testing) — last time I tested with the demos from the launch video, Merged! Unfortunately I'm not very good at git, not sure how to squeeze commits, but let me know if it's important to do and I'll figure it out! Thank you so much for this PR. |
Describe the changes you have made:
Add default context window and max tokens configs for OpenAI's new models:
gpt-4-turbo-preview
,gpt-4-0125-preview
, andgpt-4-1106-vision-preview
.Reference any relevant issues (e.g. "Fixes #000"):
If we can keep these configs updated with as more models as possible, maybe can avoid issues like #915
Pre-Submission Checklist (optional but appreciated):
docs/CONTRIBUTING.md
docs/ROADMAP.md
OS Tests (optional but appreciated):