Proposal: Enforce consistent code style with black, isort, and pre-commit #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericrallen
commented
Oct 26, 2023
There was a problem hiding this comment.
This should preserve the regular git blame history for commits prior to the automated formatting commit and only show that commit as the git blame for newly added whitespace or removed whitespace changes.
ericrallen
force-pushed
the
feature/automated-formatting
branch
from
e34be0f to
4a9d472
Compare
|
@KillianLucas the one thing I'm not sure about is if each developer needs to run We can add a note to the Contributing Guide if necessary. |
joshuavial
pushed a commit
to joshuavial/open-interpreter
that referenced
this pull request
Nov 16, 2023
…utomated-formatting Proposal: Enforce consistent code style with black, isort, and pre-commit Former-commit-id: ac71e20 Former-commit-id: 5018ae27f9892012af39e6d8c600142e62a2310f Former-commit-id: 02a4b67ef2eb7b0011863dae01bd2715c7f2c1e5 [formerly b1d3da6823de1c456064bb0686ce117c7c5c39cf] Former-commit-id: 6a270bb8b6bc2bde12a46644f836fb69340614e7
joshuavial
pushed a commit
to joshuavial/open-interpreter
that referenced
this pull request
Nov 16, 2023
…utomated-formatting Proposal: Enforce consistent code style with black, isort, and pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made:
This adds
black,isort, andpre-committo the repository and runsblackandisorton apre-commithook to help ensure that we have consistent code style across the codebase in order to eliminate a lot of the noise in Pull Requests where someone has accidentally formatted something differently due to their editor's settings.Reference any relevant issue (Fixes #000)
I have tested the code on the following OS:
AI Language Model (if applicable)