Move the entry point to start_terminal_interface #960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While talking with @Arrendy going through some code made a change to the entry point Co-Authored-By: Mike Bird <[email protected]>
and move main() to bottom Co-Authored-By: Mike Bird <[email protected]>
MikeBirdTech
approved these changes
Jan 23, 2024
| try: | ||
| start_terminal_interface(interpreter) | ||
| except KeyboardInterrupt as e: | ||
| print(e) |
There was a problem hiding this comment.
I believe e will always be an empty string. Do we want to revert to Exited. or some other message to show the user?
There was a problem hiding this comment.
It does print something, no?
Anyways, I added more Error handling and a finally:
There was a problem hiding this comment.
It didn't print anything in my testing and chatGPT says it'll always be empty. I'm no python expert though. Did it print a message in your testing?
|
Nice!! Thank you so much @Notnaton. Yes, this is much more logical. Fantastic work, merging now. (Also: really looking forward to our chat tomorrow!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While talking with @Arrendy going through some code made a change to the entry point
This is building further on the comments made in #947
Describe the changes you have made:
Reference any relevant issues (e.g. "Fixes #000"):
Pre-Submission Checklist (optional but appreciated):
docs/CONTRIBUTING.mddocs/ROADMAP.mdOS Tests (optional but appreciated):