Skip to content

Fix the conversation restoration problem in version 0.2.0 New Computer #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

Steve235lab
Copy link
Contributor

@Steve235lab Steve235lab commented Jan 27, 2024

Describe the changes you have made:

Fix the conversation restoration function with argument --conversations by updating rander_past_conversation logic.

Reference any relevant issues (e.g. "Fixes #000"):

Fixes #962

Pre-Submission Checklist (optional but appreciated):

  • I have included relevant documentation updates (stored in /docs)
  • I have read docs/CONTRIBUTING.md
  • I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux

@Steve235lab
Copy link
Contributor Author

Since it's also associated with the conversation restoration function, I fixed another little bug in conversation_navigator.py which throw an error when the user tries to exit with keyboard interruption:

Traceback (most recent call last):
  File "/usr/local/bin/interpreter", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/dist-packages/interpreter/terminal_interface/start_terminal_interface.py", line 412, in main
    start_terminal_interface(interpreter)
  File "/usr/local/lib/python3.10/dist-packages/interpreter/terminal_interface/start_terminal_interface.py", line 379, in start_terminal_interface
    conversation_navigator(interpreter)
  File "/usr/local/lib/python3.10/dist-packages/interpreter/terminal_interface/conversation_navigator.py", line 68, in conversation_navigator
    if answers["name"] == "> Open folder":
TypeError: 'NoneType' object is not subscriptable

by checking the variable answers.

@Steve235lab
Copy link
Contributor Author

Here's the outcome:

fixed_conversation_navigator.mov

@KillianLucas
Copy link
Collaborator

You're kidding me. This is excellent @Steve235lab, truly great work. Will push this to pip in the next few days.

We can also easily extend your work to fix that weird artifacts error when you scroll up— once the AI is done writing a message, we'll use this to display the entire conversation (it's the display while streaming that causes those weird artifacts when you scroll up). Two birds with one steve stone.

Merging!

@KillianLucas KillianLucas merged commit ed286c9 into openinterpreter:main Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to fix the conversation restoration problem in version 0.2.0 New Computer
2 participants