8319386: Migrate Class::getEnclosingMethod/Constructor away from old generic utilities

[liach]

Please review a patch that migrates Class::getEnclosingMethod and Class::getEnclosingConstructor's descriptor parsing from old generic utilities to more simple utilities from java.lang.invoke implementation. This will help migrate away from the old generic repositories in the future.

The getClassLoader() call plus

jdk/src/java.base/share/classes/sun/invoke/util/BytecodeDescriptor.java

Line 93 in 1a21c1a

return Class.forName(name, false, loader);

should be functionally equivalent to the previous getDeclsLoader()

jdk/src/java.base/share/classes/sun/reflect/generics/factory/CoreReflectionFactory.java

Lines 60 to 68 in 1a21c1a

	private ClassLoader getDeclsLoader() {
	if (decl instanceof Class<?> c) {return c.getClassLoader();}
	if (decl instanceof Method m) {
	return m.getDeclaringClass().getClassLoader();
	}
	assert decl instanceof Constructor : "Constructor expected";
	return ((Constructor<?>) decl).getDeclaringClass().getClassLoader();
	}

plus

jdk/src/java.base/share/classes/sun/reflect/generics/factory/CoreReflectionFactory.java

Lines 113 to 114 in 1a21c1a

	try {return Class.forName(name, false, // don't initialize
	getDeclsLoader());}

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8319386: Migrate Class::getEnclosingMethod/Constructor away from old generic utilities (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16496/head:pull/16496
$ git checkout pull/16496

Update a local copy of the PR:
$ git checkout pull/16496
$ git pull https://git.openjdk.org/jdk.git pull/16496/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16496

View PR using the GUI difftool:
$ git pr show -t 16496

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16496.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (885c50ba)

[bridgekeeper]

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@liach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[liach]

/open

[openjdk]

@liach This pull request is now open

[bridgekeeper]

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@liach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[liach]

/open

Please review this patch that migrated descriptor parsing from old, complex Java 5 signature parsing system to the java.lang.invoke's descriptor parsing utilities.

[openjdk]

@liach This pull request is now open

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[bridgekeeper]

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@liach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[liach]

/open

[openjdk]

@liach This pull request is now open

[liach]

Superseded by #19281