Skip to content

Conversation

mur47x111
Copy link
Contributor

@mur47x111 mur47x111 commented May 26, 2025

Return unmodifiable list instead of new arrays.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warnings

 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletColor16.gif)
 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletColor32.gif)
 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletMono16.gif)
 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletMono32.gif)
 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/doc-files/JRootPane-1.gif)
 ⚠️ Patch contains a binary file (test/jdk/javax/rmi/ssl/keystore)
 ⚠️ Patch contains a binary file (test/jdk/javax/rmi/ssl/truststore)
 ⚠️ Patch contains a binary file (test/jdk/jdk/internal/loader/URLClassPath/testclasses.jar)
 ⚠️ Patch contains a binary file (test/jdk/sun/net/www/protocol/https/HttpsClient/dnsstore)
 ⚠️ Patch contains a binary file (test/jdk/sun/net/www/protocol/https/HttpsClient/ipstore)

Issue

  • JDK-8351268: [JVMCI] Enhance JVMCI by leveraging modern Java features (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25442/head:pull/25442
$ git checkout pull/25442

Update a local copy of the PR:
$ git checkout pull/25442
$ git pull https://git.openjdk.org/jdk.git pull/25442/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25442

View PR using the GUI difftool:
$ git pr show -t 25442

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25442.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 26, 2025

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 26, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented May 26, 2025

@mur47x111 The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@dougxc
Copy link
Member

dougxc commented May 27, 2025

Please try come up with a jtreg test that prevents introduction of new JVMCI methods returning arrays. Some kind of white list approach is probably best.

* Note that the number of locals and the number of stack slots may be smaller than the maximum
* number of locals and stack slots as specified in the compiled method.
*
* This field is intentionally exposed as a mutable array that a compiler may modify (e.g.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutable array -> mutable list

@openjdk
Copy link

openjdk bot commented Jun 3, 2025

@mur47x111 this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8351268
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Jun 3, 2025
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Jun 16, 2025
@mur47x111 mur47x111 changed the title 8351268: [JVMCI] Replace raw arrays with List 8351268: [JVMCI] Enhance JVMCI by leveraging modern Java features Jun 20, 2025
@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Jun 20, 2025
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Jun 20, 2025
@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Aug 6, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2025

@mur47x111 This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants