8360515: PROPERFMTARGS should always use size_t template specialization for unit

[jsikstro]

Hello,

PROPERFMT is defined as the format string "%zu%s", which expects a size_t as input argument. When used in combination with PROPERFMTARGS, which uses the templated byte_size_in_proper_units, the byte size may not be size_t if the input is some other type.

To minimize confusion, PROPERFMTARGS should always use the size_t template specilization of byte_size_in_proper_units, to match PROPERFMT. Places that use byte_size_in_proper_units with other types can still use it, but should use their own format strings instead of PROPERFMT.

ProcSmapsSummary::print_on in memMapPrinter_macosx is the only place that uses PROPERFMTARGS with a type that is not size_t. I have changed those places to use the expanded version of the macro, which uses the templated version of byte_size_in_proper_unit instead.

Testing:

• Oracle's tier1-2

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8360515: PROPERFMTARGS should always use size_t template specialization for unit (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25975/head:pull/25975
$ git checkout pull/25975

Update a local copy of the PR:
$ git checkout pull/25975
$ git pull https://git.openjdk.org/jdk.git pull/25975/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25975

View PR using the GUI difftool:
$ git pr show -t 25975

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25975.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@jsikstro The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0d51cb39)
• 00: Full (1e340fab)

[dholmes-ora]

Just to clarify something for the reader here, as it tripped me up, the vm_info fields are declared as mach_vm_size_t, which one might expect is some kind of size_t but alas no [1]:

typedef uint64_t mach_vm_size_t;

But given you cast page_size to size_t (it is int32_t) why not cast the others too and use PROPERFMT?

[1] https://developer.apple.com/documentation/kernel/mach_vm_size_t

[jsikstro]

I originally wanted this patch to be minimally invasive and just fix the mismatch between PROPERFMT and PROPERFMTARGS. The cast to size_t wasn't added by me, I just changed the format specifier to match the type in PROPERFMTARGS. I agree that it looks a bit weird to have both the expanded macro and PROPERFMTARGS next to each other, and I'm not 100% sure why vm_info.page_size is casted to size_t.

I'm fine with making the usage consistent in this patch, making all the prints use PROPERFMT+PROPERFMTARGS with casts to size_t, or the other way around using the expanded macro.

[dholmes-ora]

Sorry for mis-attributing the cast to your change. This could go either way with no way clearly better than the other. Lets see if another reviewer has a strong opinion.