Skip to content

8360518: Docker tests do not work when asan is configured #25980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jun 25, 2025

When the address sanitizer ASAN is configured, we run into errors in the docker tests.
Example hotspot/jtreg/containers/docker/DockerBasicTest.java :

[STDOUT]
/jdk/bin/java: error while loading shared libraries: libasan.so.8: cannot open shared object file: No such file or directory

Reason is that the asan-enabled binaries need additional dependencies and those are not available in the current docker/container setups.
Maybe we should skip those tests when asan is enabled.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8360518: Docker tests do not work when asan is configured (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25980/head:pull/25980
$ git checkout pull/25980

Update a local copy of the PR:
$ git checkout pull/25980
$ git pull https://git.openjdk.org/jdk.git pull/25980/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25980

View PR using the GUI difftool:
$ git pr show -t 25980

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25980.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 25, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 25, 2025

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360518: Docker tests do not work when asan is configured

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8360518: Docker tests do not work when asan is configured 8360518: Docker tests do not work when asan is configured Jun 25, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 25, 2025
@openjdk
Copy link

openjdk bot commented Jun 25, 2025

@MBaesken The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 25, 2025

Webrevs

@sendaoYan
Copy link
Member

Should we should copy the dependent files such as libasan.so.8 to docker images when build it.

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 26, 2025
@jerboaa
Copy link
Contributor

jerboaa commented Jun 26, 2025

Should we should copy the dependent files such as libasan.so.8 to docker images when build it.

See:
https://bugs.openjdk.org/browse/JDK-8333144?focusedId=14792939&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14792939

@MBaesken
Copy link
Member Author

Thanks for the review !

/integrate

@openjdk
Copy link

openjdk bot commented Jun 27, 2025

Going to push as commit 01b15bc.
Since your change was applied there have been 24 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2025
@openjdk openjdk bot closed this Jun 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2025
@openjdk
Copy link

openjdk bot commented Jun 27, 2025

@MBaesken Pushed as commit 01b15bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants