-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8360518: Docker tests do not work when asan is configured #25980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@MBaesken The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Should we should copy the dependent files such as libasan.so.8 to docker images when build it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me.
|
Thanks for the review ! /integrate |
Going to push as commit 01b15bc.
Your commit was automatically rebased without conflicts. |
When the address sanitizer ASAN is configured, we run into errors in the docker tests.
Example hotspot/jtreg/containers/docker/DockerBasicTest.java :
[STDOUT]
/jdk/bin/java: error while loading shared libraries: libasan.so.8: cannot open shared object file: No such file or directory
Reason is that the asan-enabled binaries need additional dependencies and those are not available in the current docker/container setups.
Maybe we should skip those tests when asan is enabled.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25980/head:pull/25980
$ git checkout pull/25980
Update a local copy of the PR:
$ git checkout pull/25980
$ git pull https://git.openjdk.org/jdk.git pull/25980/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25980
View PR using the GUI difftool:
$ git pr show -t 25980
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25980.diff
Using Webrev
Link to Webrev Comment