-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8314488: Compiling the JDK with C++17 #25992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@kimbarrett The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/label remove build |
@kimbarrett |
@kimbarrett |
1e4c3af
to
3dcf826
Compare
@kimbarrett Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
I'm hijacking the PR mechanism as a way to discuss new C++17 features that can
be more easily structured and captured than bare email. Once discussion
settles down I'll turn the results into HotSpot Style Guide changes. I don't
intend to integrate any version of this document to the OpenJDK repository.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25992/head:pull/25992
$ git checkout pull/25992
Update a local copy of the PR:
$ git checkout pull/25992
$ git pull https://git.openjdk.org/jdk.git pull/25992/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25992
View PR using the GUI difftool:
$ git pr show -t 25992
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25992.diff
Using Webrev
Link to Webrev Comment