Skip to content

8314488: Compiling the JDK with C++17 #25992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Jun 26, 2025

I'm hijacking the PR mechanism as a way to discuss new C++17 features that can
be more easily structured and captured than bare email. Once discussion
settles down I'll turn the results into HotSpot Style Guide changes. I don't
intend to integrate any version of this document to the OpenJDK repository.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314488: Compiling the JDK with C++17 (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25992/head:pull/25992
$ git checkout pull/25992

Update a local copy of the PR:
$ git checkout pull/25992
$ git pull https://git.openjdk.org/jdk.git pull/25992/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25992

View PR using the GUI difftool:
$ git pr show -t 25992

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25992.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2025

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 26, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 26, 2025

@kimbarrett The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@kimbarrett
Copy link
Author

/label remove build
/label add hotspot

@openjdk
Copy link

openjdk bot commented Jun 26, 2025

@kimbarrett
The build label was successfully removed.

@openjdk
Copy link

openjdk bot commented Jun 26, 2025

@kimbarrett
The hotspot label was successfully added.

@openjdk
Copy link

openjdk bot commented Jun 26, 2025

@kimbarrett Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@kimbarrett kimbarrett changed the title RFC: Compiling the JDK with C++17 and HotSpot use of new features 8314488: Compiling the JDK with C++17 Jun 26, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 26, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 26, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant