Skip to content

8338474: Parallel: Deprecate and obsolete PSChunkLargeArrays #25997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jun 26, 2025

Deprecating PSChunkLargeArrays, which is used only by Parallel and it is enabled by default.

Disabling it offers little benefit, so removing it do reduce the number of commandline flags.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8360628 to be approved

Issues

  • JDK-8338474: Parallel: Deprecate and obsolete PSChunkLargeArrays (Enhancement - P4)
  • JDK-8360628: Parallel: Deprecate and obsolete PSChunkLargeArrays (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25997/head:pull/25997
$ git checkout pull/25997

Update a local copy of the PR:
$ git checkout pull/25997
$ git pull https://git.openjdk.org/jdk.git pull/25997/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25997

View PR using the GUI difftool:
$ git pr show -t 25997

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25997.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2025

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 26, 2025

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338474: Parallel: Deprecate and obsolete PSChunkLargeArrays

Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8338474 8338474: Parallel: Deprecate and obsolete PSChunkLargeArrays Jun 26, 2025
@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jun 26, 2025
@openjdk
Copy link

openjdk bot commented Jun 26, 2025

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 26, 2025

Webrevs

@albertnetymk
Copy link
Member Author

/cc hotspot-gc

@openjdk
Copy link

openjdk bot commented Jun 26, 2025

@albertnetymk
The hotspot-gc label was successfully added.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Jun 30, 2025
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 2, 2025

Going to push as commit 832bfbc.
Since your change was applied there have been 64 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 2, 2025
@openjdk openjdk bot closed this Jul 2, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 2, 2025
@openjdk
Copy link

openjdk bot commented Jul 2, 2025

@albertnetymk Pushed as commit 832bfbc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the pgc-deprecate branch July 2, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants