Skip to content

8365052: G1: Remove G1CollectionSet::groups() accessors #26688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: pr/26670
Choose a base branch
from

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Aug 8, 2025

Hi all,

please review this small change that remove the public G1CollectionSet::groups() accessors because they are never used from outside the G1CollectionSet class.

Testing: local compilation, gha

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #26670 must be integrated first

Issue

  • JDK-8365052: G1: Remove G1CollectionSet::groups() accessors (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26688/head:pull/26688
$ git checkout pull/26688

Update a local copy of the PR:
$ git checkout pull/26688
$ git pull https://git.openjdk.org/jdk.git pull/26688/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26688

View PR using the GUI difftool:
$ git pr show -t 26688

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26688.diff

Using Webrev

Link to Webrev Comment

Hi all,

  please review this small change that remove the public `G1CollectionSet::groups()` accessors because they are never used from outside the `G1CollectionSet` class.

Testing: local compilation, gha

Thanks,
  Thomas
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 8, 2025

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into pr/26670 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 8, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8365052 8365052: G1: Remove G1CollectionSet::groups() accessors Aug 8, 2025
@openjdk
Copy link

openjdk bot commented Aug 8, 2025

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc [email protected] rfr Pull request is ready for review labels Aug 8, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 8, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant