8365122: G1: Minor clean up of G1SurvivorRegions

[tschatzl]

Hi all,

please review this small cleanup around G1SurvivorRegions:

• make the _regions member a direct member of the class
• use the C++ for-each construct for iterating over _regions makes the code more readable

Testing: gha

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365122: G1: Minor clean up of G1SurvivorRegions (Enhancement - P4)

Reviewers

• Sangheon Kim (@sangheon - Reviewer)
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26692/head:pull/26692
$ git checkout pull/26692

Update a local copy of the PR:
$ git checkout pull/26692
$ git pull https://git.openjdk.org/jdk.git pull/26692/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26692

View PR using the GUI difftool:
$ git pr show -t 26692

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26692.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365122: G1: Minor clean up of G1SurvivorRegions

Reviewed-by: sangheki, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• d78fa5a: 8365240: [asan] exclude some tests when using asan enabled binaries
• 72d3a2a: 8308349: missing working directory option for launcher when invoked from shortcuts
• 6927fc3: 8365200: RISC-V: compiler/loopopts/superword/TestGeneralizedReductions.java fails with Zvbb and vlen=128
• ... and 24 more: https://git.openjdk.org/jdk/compare/1b3e23110b2262e470a8c520b977273fd6a9e8d1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (16244cad)
• 00: Full (b73da8fc)

[sangheon]

Looks good.

[kimbarrett]

Looks good.

[tschatzl]

Thanks @sangheon @kimbarrett for your reviews
/integrate

[openjdk]

Going to push as commit 16e461e.
Since your change was applied there have been 32 commits pushed to the master branch:

• 3c0eed8: 8364406: Remove LockingMode related code from aarch64
• f155f7d: 8364141: Remove LockingMode related code from x86
• b81f4fa: 8360037: Refactor ImageReader in preparation for Valhalla support
• ... and 29 more: https://git.openjdk.org/jdk/compare/1b3e23110b2262e470a8c520b977273fd6a9e8d1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 16e461e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.