8341342: Elements.getAllModuleElements() does not work properly before JavacTask.analyze()

[lahodaj]

When calling Elements.getTypeElement(...) or Elements.getPackageElement(...), javac itself ensures that the enter phase is already done. That is, sadly, not done for Elements.getAllModuleElements(). This PR fixes that.

See:
https://github.com/openjdk/jdk/pull/18934/files#r1767657515
for a practical case.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341342: Elements.getAllModuleElements() does not work properly before JavacTask.analyze() (Bug - P4)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)
• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26694/head:pull/26694
$ git checkout pull/26694

Update a local copy of the PR:
$ git checkout pull/26694
$ git pull https://git.openjdk.org/jdk.git pull/26694/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26694

View PR using the GUI difftool:
$ git pr show -t 26694

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26694.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341342: Elements.getAllModuleElements() does not work properly before JavacTask.analyze()

Reviewed-by: vromero, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• a382996: 8364993: JFR: Disable jdk.ModuleExport in default.jfc
• 391ea15: 8365307: AIX make fails after JDK-8364611
• 19a76a4: 8365316: Remove unnecessary default arg value in gcVMOperations
• ... and 39 more: https://git.openjdk.org/jdk/compare/d0624f8b62fe0c70e5b6a47e05235ca65a2e1a13...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (5462926c)
• 01: Full - Incremental (8651514c)
• 00: Full (358378db)

[liach]

I remember this from the APIDiff: https://github.com/openjdk/apidiff/blob/1dbbcb5b87f75edcbdf9caf7314c56bce1a110df/src/share/classes/jdk/codetools/apidiff/model/API.java#L460

[liach]

You can use @ParameterizedTest @MethodSource("taskFactory") for each test case, and static JavacTask taskFactory() { /* ... */} for junit to call to create the task argument for each test.

[vicente-romero-oracle]

lgtm

[liach]

Thanks. This test is indeed a bit hard to organize due to being stateful. We can reorganize it if we need later.