8365055: G1: Merge Heap Roots phase incorrectly clears young gen remembered set every time

[tschatzl]

Hi all,

please review this fix to G1 heap root merging that cleared the young gen remembered set multiple times (for every merging) and overwriting the most recent statistics for the number of young gen cards.

The latter is probably the more problematic, as it directly impacts young gen sizing statistics, potentially making young gen too large.

The fix is to move the two statements to the proper place - get current number of young gen cards at startup, clear the young gen remset when starting a new collection set - we do not need to do that earlier after all. Additionally we can add some (superfluous?) verification that during GC we really do not add to the young gen remset.

Testing: tier1-5

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365055: G1: Merge Heap Roots phase incorrectly clears young gen remembered set every time (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26695/head:pull/26695
$ git checkout pull/26695

Update a local copy of the PR:
$ git checkout pull/26695
$ git pull https://git.openjdk.org/jdk.git pull/26695/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26695

View PR using the GUI difftool:
$ git pr show -t 26695

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26695.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ba62be50)
• 00: Full (857fdf91)