Skip to content

8365146: Remove LockingMode related code from ppc64 #26697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fbredber
Copy link
Contributor

@fbredber fbredber commented Aug 8, 2025

Since the integration of JDK-8359437 the LockingMode flag can no longer be set by the user, instead it's declared as const int LockingMode = LM_LIGHTWEIGHT;. This means that we can now safely remove all LockingMode related code from all platforms.

This PR removes LockingMode related code from the ppc64le platform.

When all the LockingMode code has been removed from all platforms, we can go on and remove it from shared (non-platform specific) files as well. And finally remove the LockingMode variable itself.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365146: Remove LockingMode related code from ppc64 (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26697/head:pull/26697
$ git checkout pull/26697

Update a local copy of the PR:
$ git checkout pull/26697
$ git pull https://git.openjdk.org/jdk.git pull/26697/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26697

View PR using the GUI difftool:
$ git pr show -t 26697

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26697.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 8, 2025

👋 Welcome back fbredberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 8, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Aug 8, 2025

@fbredber The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@fbredber
Copy link
Contributor Author

fbredber commented Aug 8, 2025

/label remove hotspot
/label add hotspot-runtime

@openjdk
Copy link

openjdk bot commented Aug 8, 2025

@fbredber
The hotspot label was successfully removed.

@openjdk
Copy link

openjdk bot commented Aug 8, 2025

@fbredber
The hotspot-runtime label was successfully added.

@fbredber fbredber marked this pull request as ready for review August 8, 2025 14:15
@fbredber
Copy link
Contributor Author

fbredber commented Aug 8, 2025

@TheRealMDoerr (or @reinrich)
I've run rudimentary tests using QEMU, but it would be nice if you could take it for a spin on real hardware.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 8, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 8, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant