8346005: Parallel: Incorrect page size calculation with UseLargePages #26700
+140
−149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the heap-space and OS memory interface code to clearly separate two related but distinct concepts:
alignment
andos-page-size
. These are now represented as two fields inPSVirtualSpace
.The parallel heap consists of four spaces: old, eden, from, and to. The first belongs to the old generation, while the latter three belong to the young generation.
The size of any space is always aligned to
alignment
, which also determines the unit for resizing. To keep the implementation simple while allowing flexible per-space commit and uncommit operations, each space must contain at least one OS page. As a result,alignment
is always greater than or equal toos-page-size
.When using explicit large pages -- which require pre-allocating large pages before the VM starts -- the actual OS page size is not known until the heap has been reserved. The additional logic in
ParallelScavengeHeap::initialize
detects the OS page size in use and adjustsalignment
if necessary.Test: tier1–8
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26700/head:pull/26700
$ git checkout pull/26700
Update a local copy of the PR:
$ git checkout pull/26700
$ git pull https://git.openjdk.org/jdk.git pull/26700/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26700
View PR using the GUI difftool:
$ git pr show -t 26700
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26700.diff
Using Webrev
Link to Webrev Comment