8364752: Class java.time.Instant cannot parse all ISO 8601 date formats #26708
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instant.parse()
is expected to use the offset zone pattern+HH:mm:ss
(as defined byDateTimeFormatterBuilder.appendOffsetId()
), but it fails to parse hour-only offsets such as+02
. This is because the actual implementation uses+HH:MM:ss
as the pattern. While replacing the pattern in the implementation as with the specification would allow hour-only offsets, it would also introduce compatibility issues, i.e., printing would omit the minutes field when it is zero. So, it is preferable to update the specification to match the implementation. A CSR has also been drafted for this change.Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26708/head:pull/26708
$ git checkout pull/26708
Update a local copy of the PR:
$ git checkout pull/26708
$ git pull https://git.openjdk.org/jdk.git pull/26708/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26708
View PR using the GUI difftool:
$ git pr show -t 26708
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26708.diff
Using Webrev
Link to Webrev Comment