Skip to content

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Sep 22, 2025

Please review this PR which incorporates ISO 4217 update 180 into the Currency data. Bulgaria (GMT+2) now transitions to Euro, effective on the 1st of January 2026. Changes also include removal of now defunct cut overs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368308: ISO 4217 Amendment 180 Update (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27433/head:pull/27433
$ git checkout pull/27433

Update a local copy of the PR:
$ git checkout pull/27433
$ git pull https://git.openjdk.org/jdk.git pull/27433/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27433

View PR using the GUI difftool:
$ git pr show -t 27433

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27433.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2025

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 22, 2025

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368308: ISO 4217 Amendment 180 Update

Reviewed-by: naoto, iris, coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8368308: ISO 4217 Amendment 180 Update 8368308: ISO 4217 Amendment 180 Update Sep 22, 2025
@openjdk
Copy link

openjdk bot commented Sep 22, 2025

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 22, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2025

Webrevs

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes appear to reflect the most recent amendment.

Thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 22, 2025
@justin-curtis-lu
Copy link
Member Author

Thank you all for the reviews.
/integrate

@openjdk
Copy link

openjdk bot commented Sep 24, 2025

Going to push as commit 85f5bf3.
Since your change was applied there have been 51 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 24, 2025
@openjdk openjdk bot closed this Sep 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 24, 2025
@openjdk
Copy link

openjdk bot commented Sep 24, 2025

@justin-curtis-lu Pushed as commit 85f5bf3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants