8365191: Cleanup after removing LockingMode related code

[fbredber]

This is a general cleanup after removing LockingMode related code.
It's a sub-task of JDK-8344261.
It includes:

• Removing asserts that are no longer necessary, since we removed legacy locking and monitor locking.
• Removing or rewriting comments, arguments or functions that are related to displaced headers.
• Remove "always true" parameter from MonitorExitStub.
• Re-type/name metadata in BasicLock.

Tier1-5 passes okay on supported platforms.

All other platforms (arm, ppc, riscv and s390) has been sanity checked using Qemu.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365191: Cleanup after removing LockingMode related code (Sub-task - P4)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer) Review applies to b5d57851
• Albert Mingkun Yang (@albertnetymk - Reviewer) Review applies to b5d57851
• Coleen Phillimore (@coleenp - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)
• Fei Yang (@RealFYang - Reviewer) Review applies to b5d57851
• Amit Kumar (@offamitkumar - Committer) Review applies to b5d57851
• Yudi Zheng (@mur47x111 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27448/head:pull/27448
$ git checkout pull/27448

Update a local copy of the PR:
$ git checkout pull/27448
$ git pull https://git.openjdk.org/jdk.git pull/27448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27448

View PR using the GUI difftool:
$ git pr show -t 27448

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27448.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fbredberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fbredber This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365191: Cleanup after removing LockingMode related code

Reviewed-by: coleenp, dholmes, yzheng, mdoerr, ayang, fyang, amitkumar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 120 new commits pushed to the master branch:

• 2aafda1: 8366948: AOT cache creation crashes when iterating training data
• a2870d6: 8368015: Shenandoah: fix error in computation of average allocation rate
• 17accf4: 8368174: Proactive initialization of @AOTSafeClassInitializer classes
• ... and 117 more: https://git.openjdk.org/jdk/compare/feaa654b1bb5a1187785320603ccb17e2c43222d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@fbredber The following labels will be automatically applied to this pull request:

• graal
• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (43f9c0af)
• 01: Full - Incremental (85457638)
• 00: Full (b5d57851)

[fbredber]

@bulasevich, @TheRealMDoerr, @RealFYang, @offamitkumar
I've run rudimentary tests using QEMU, but it would be nice if you guys (or any of your friends) could take it for a spin on real hardware. Thanks in advance.

[TheRealMDoerr]

PPC64 and hotspot/share/c1 changes LGTM. Thanks for cleaning it up!

[coleenp]

This looks really good with a couple of minor comments.

[dholmes-ora]

LGTM2

[RealFYang]

@fbredber : Thanks for the ping. Tier1 test passes on linux-riscv64 platform.
The RISC-V part of the change seems fine modulo one minor nit.

[offamitkumar]

s390x Part looks good. tier1 tests with fastdebug and release vm seems stable as well.

[coleenp]

Looks good!

[mur47x111]

LGTM

[dholmes-ora]

Still good.

[fbredber]

Thank you all for the reviews. Now let's...

/integrate

[openjdk]

Going to push as commit 847b107.
Since your change was applied there have been 122 commits pushed to the master branch:

• e6ddb39: 8368525: nmethod ic cleanup
• 17244c6: 8368159: Significant performance overhead when started with jdwp agent and unattached debugger
• 2aafda1: 8366948: AOT cache creation crashes when iterating training data
• ... and 119 more: https://git.openjdk.org/jdk/compare/feaa654b1bb5a1187785320603ccb17e2c43222d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@fbredber Pushed as commit 847b107.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.