Skip to content

Conversation

jdksjolen
Copy link
Contributor

@jdksjolen jdksjolen commented Sep 23, 2025

Small (trivial?) refactoring now that we have C++17, also changed the UL example.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27454/head:pull/27454
$ git checkout pull/27454

Update a local copy of the PR:
$ git checkout pull/27454
$ git pull https://git.openjdk.org/jdk.git pull/27454/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27454

View PR using the GUI difftool:
$ git pr show -t 27454

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27454.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2025

👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 23, 2025

@jdksjolen The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@jdksjolen jdksjolen marked this pull request as ready for review September 29, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant