8366948: AOT cache creation crashes when iterating training data

[veresov]

I forgot a lock around CTD::_ci_records. It also has to respect the snapshotting protocol. Testing is good.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8366948: AOT cache creation crashes when iterating training data (Bug - P2)

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27461/head:pull/27461
$ git checkout pull/27461

Update a local copy of the PR:
$ git checkout pull/27461
$ git pull https://git.openjdk.org/jdk.git pull/27461/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27461

View PR using the GUI difftool:
$ git pr show -t 27461

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27461.diff

Using Webrev

Link to Webrev Comment

[veresov]

/label add hotspot-compiler

[bridgekeeper]

👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@veresov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366948: AOT cache creation crashes when iterating training data

Reviewed-by: vlivanov, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 17accf4: 8368174: Proactive initialization of @AOTSafeClassInitializer classes
• 8f87fdc: 8368182: AOT cache creation fails with class defined by JNI
• 5d93242: 8368335: Refactor the rest of Locale TestNG based tests to JUnit
• ... and 28 more: https://git.openjdk.org/jdk/compare/4df04a254397836b1bfe384ac9e6413e1ff9b242...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@veresov
The hotspot-compiler label was successfully added.

[openjdk]

@veresov The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (bb3add97)
• 00: Full (6fc9d856)

[iwanowww]

Looks good.

[veresov]

Thanks guys!
/integrate

[openjdk]

Going to push as commit 2aafda1.
Since your change was applied there have been 32 commits pushed to the master branch:

• a2870d6: 8368015: Shenandoah: fix error in computation of average allocation rate
• 17accf4: 8368174: Proactive initialization of @AOTSafeClassInitializer classes
• 8f87fdc: 8368182: AOT cache creation fails with class defined by JNI
• ... and 29 more: https://git.openjdk.org/jdk/compare/4df04a254397836b1bfe384ac9e6413e1ff9b242...master

Your commit was automatically rebased without conflicts.

[openjdk]

@veresov Pushed as commit 2aafda1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[veresov]

/backport jdk25u

[openjdk]

@veresov the backport was successfully created on the branch backport-veresov-2aafda19-master in my personal fork of openjdk/jdk25u. To create a pull request with this backport targeting openjdk/jdk25u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 2aafda19 from the openjdk/jdk repository.

The commit being backported was authored by Igor Veresov on 24 Sep 2025 and was reviewed by Vladimir Ivanov and Ioi Lam.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk25u:

$ git fetch https://github.com/openjdk-bots/jdk25u.git backport-veresov-2aafda19-master:backport-veresov-2aafda19-master
$ git checkout backport-veresov-2aafda19-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk25u.git backport-veresov-2aafda19-master

⚠️ @veresov You are not yet a collaborator in my fork openjdk-bots/jdk25u. An invite will be sent out and you need to accept it before you can proceed.