8224087: Compile C code for at least C99 Standard compliance

[zzambers]

This backport explicitly sets c99 standard for jdk c sources on compilers, where appropriate. Motivation for this is, recent gcc switch to c23 as default, causing errors (jdk sources are not c23 compatible).

Main problem is, that c23 no longer supports non-prototype function declarations (see (3) here). Example errors:

/mnt/ramdisk/java-11-openjdk-11.0.28.0.6-1.portable.jdk.el.x86_64.tarxz/src/src/java.base/unix/native/libnet/DefaultProxySelector.c:389:16: error: too many arguments to function 'g_proxy_resolver_lookup'; expected 0, have 4
  389 |     proxies = (*g_proxy_resolver_lookup)(resolver, uri, NULL, &error);
      |               ~^~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~

/mnt/ramdisk/java-11-openjdk-11.0.28.0.6-1.portable.jdk.el.x86_64.tarxz/src/test/hotspot/jtreg/runtime/jsig/libTestJNI.c:45:22: error: assignment to 'void (*)(int,  siginfo_t *, void *)' from incompatible pointer type 'void (*)(void)' [-Wincompatible-pointer-types]
   45 |     act.sa_sigaction = (void (*)())sig_handler;
      |                      ^

There are more, if above are fixed. Non prototype function declarations are present even in newest jdk, but newer jdks have c standard set explicitly, so they do not cause errors there.

This should not increase minimum requirements for compiler toolchains needed to build jdk11. Jdk13, where this originates from, has same minimal compiler requirements as jdk11. ( gcc 4.8, clang 3.2, Xcode 8, Solaris Studio 12.4)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8224087 needs maintainer approval

Issue

• JDK-8224087: Compile C code for at least C99 Standard compliance (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3087/head:pull/3087
$ git checkout pull/3087

Update a local copy of the PR:
$ git checkout pull/3087
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3087/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3087

View PR using the GUI difftool:
$ git pr show -t 3087

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3087.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (e7e9318a)

[gnu-andrew]

I'm in two minds about this. Specifying the standard explicitly is the right thing to do (I added similar for C++ years back) but we could just make that C90 so as to not raise older compilers.

I think, given some compilers have been defaulting to C99 for some time anyway (and maybe even later), this should be safe and may avoid problems with future backports. Let's get it in early and ensure it is well tested before January.

What compilers have you tested this change with?

[zzambers]

I was also thinking, whether c99 is ok here, but given that jdk13 has same minimum compiler versions, it should be safe.

Apart from testing in GHA. I tested these compiler versions (WORK):

• gcc-15.2.1 (f42; original motivation for this backport)
• gcc-4.8.5 (rhel-7)
• clang-3.8.1 (debian stretch)

Minimum accepted versions are gcc-4.8 and clang 3.2, so I tried to get close to that, based on what is available in old rhel/debian, not building my own toolchain. (Debian Jessie has clang 3.5, but that one (clang) was segfaulting during the build even on master, and Wheezy has clang 3.0)
(builds needed to disable warnings as errors, but that was same for master (and warnings seem the same))

For msvc there should be no change in compiler flags by this backport.

When it comes to Solaris, I could not test build there, because I don't have that OS available to me. But given that some awt libraries were already compiled with c99 flags, compiler flags should work.

[zzambers]

Build logs:
jdk-c99-logs.tar.gz