8337102: JITTester: Fix breaks in static initialization blocks

[kirill-shirokov]

---

Progress

• JDK-8337102 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

• JDK-8337102: JITTester: Fix breaks in static initialization blocks (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3094/head:pull/3094
$ git checkout pull/3094

Update a local copy of the PR:
$ git checkout pull/3094
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3094/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3094

View PR using the GUI difftool:
$ git pr show -t 3094

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3094.diff

[bridgekeeper]

Hi @kirill-shirokov, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user kirill-shirokov" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[kirill-shirokov]

Verified on Mac + Linux + Windows:

Unfixed version:

% cd test/hotspot/jtreg/testlibrary/jittester
% sed -i '' '/disable-static/{s!true!false!;}' conf/default.properties
% make install JDK_HOME=$JAVA_HOME TESTS_NUMBER=1

Produces frequent failures in javac output files, like:

% grep -r break ws/hotspot/test/
...
ws/hotspot/test/aot_java_tests/Test_0.err:ws/hotspot/test/aot_java_tests/Test_0.java:61: error: break outside switch or loop
ws/hotspot/test/aot_java_tests/Test_0.err:            break; /* 0 */
ws/hotspot/test/aot_java_tests/Test_0.err:ws/hotspot/test/aot_java_tests/Test_0.java:297: error: break outside switch or loop
ws/hotspot/test/aot_java_tests/Test_0.err:            break; /* 0 */
...

...with generated .java files having 'break;' statements in static {...}

Fixed version:

(no default.properties modification is needed, there is already disable-static=false)

% cd test/hotspot/jtreg/testlibrary/jittester
% make install JDK_HOME=$JAVA_HOME TESTS_NUMBER=500

Not getting any failures in general case:

Generating 500 tests...
    start time |    count |  generat |  running |
           --- |      --- |      --- |      --- |
[15:15:53.559049] |        0 |     3945 |   121109 |
[15:17:58.608076] |        1 |     1789 |     1076 |
[15:18:01.474781] |        2 |     1735 |     1058 |
[15:18:04.268104] |        3 |     1805 |     1021 |
[15:18:07.094167] |        4 |     1728 |     1074 |
[15:18:09.896595] |        5 |     1908 |     1030 |
[15:18:12.834347] |        6 |      495 |      984 |
...
% grep -r "error: break outside switch or loop" ws/hotspot/test/
%

[kirill-shirokov]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!