8342075: HttpClient: improve HTTP/2 flow control checks

[GoeLin]

I backport this for parity with 17.0.17-oracle based on the change in 21.

src/java.net.http/share/classes/jdk/internal/net/http/Stream.java
Two trivial resolves due to context.

src/java.net.http/share/classes/jdk/internal/net/http/WindowUpdateSender.java

Resolved because 8308310: HttpClient: Avoid logging or locking from within synchronized blocks
is not in 17.

src/java.net.http/share/classes/module-info.java
Omitted, as "8296804: Document HttpClient configuration properties in java.net.http module-info"
is not in 17. The CSR for 17 documents that this is dropped.

Follow ups are on the list of backports I will do.
Blocking changes all already in 17.

I had to adapt ConnectionFlowControlTest.java and StreamFlowControlTest.java because HttpClient does not
implement AutoClosable / shutdownNow() / close() in 17.
I also amended the @build instructions in StreamFlowControlTest.java.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8342075 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8351085 to be approved

Issues

• JDK-8342075: HttpClient: improve HTTP/2 flow control checks (Bug - P4 - Requested)
• JDK-8351085: HttpClient: improve HTTP/2 flow control checks (CSR)

Reviewers

• Alexey Bakhtin (@alexeybakhtin - Reviewer) Review applies to 211a4553
• Ralf Schmelter (@schmelter-sap - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3786/head:pull/3786
$ git checkout pull/3786

Update a local copy of the PR:
$ git checkout pull/3786
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3786/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3786

View PR using the GUI difftool:
$ git pr show -t 3786

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3786.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 04: Full (f9cbc600)
• 03: Full - Incremental (073bb3d5)
• 02: Full - Incremental (c86d9d24)
• 01: Full (3349b52e)
• 00: Full (211a4553)

[alexeybakhtin]

Thank you for the backport! The changes look good to me

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[GoeLin]

HI @alexeybakhtin
I saw in #3298 that you are using a ThreadPool in the tests.
I think this is a useful improvement. Should I add that to my change here?

[alexeybakhtin]

HI @alexeybakhtin I saw in #3298 that you are using a ThreadPool in the tests. I think this is a useful improvement. Should I add that to my change here?

Yes, I forgot about these changes. I think they could be useful here to clean up resources.

[GoeLin]

Thanks, I added them.

[schmelter-sap]

Looks good.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.