-
Notifications
You must be signed in to change notification settings - Fork 170
6986863: ProfileDeferralMgr throwing ConcurrentModificationException #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pr/690
Are you sure you want to change the base?
Conversation
👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
ea13d13
to
322a0c9
Compare
@jankratochvil this pull request can not be integrated into git checkout 8263622-6986863
git fetch https://git.openjdk.org/jdk8u-dev.git pr/690
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/690"
git push |
50ad5e5
to
1fade41
Compare
Reviewed-by: kizune
322a0c9
to
0fe4334
Compare
The CI errors are false positives, they are the same as unpatched sources tested in: jankratochvil#1 |
It is needed in jdk8 as a prerequisite for JDK-8347377.
A testcase is included.
It is not a clean backport - source files are moved, copyright years update, original patch uses extra function getStandardProfileInputStream(), Anton Voznia hasn't implemented it by himself, he borrowed it from another patch https://bugs.openjdk.org/browse/JDK-8039271 and changed it a bit according to the requirements. He didn't include entire fix because it's redundant.
This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle.
It requires #690 as a prerequisite.
Progress
Integration blocker
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/691/head:pull/691
$ git checkout pull/691
Update a local copy of the PR:
$ git checkout pull/691
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/691/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 691
View PR using the GUI difftool:
$ git pr show -t 691
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/691.diff
Using Webrev
Link to Webrev Comment