Skip to content

Conversation

GuySten
Copy link
Contributor

@GuySten GuySten commented Jun 16, 2025

Description

This pr change the implementation of combine_distributions to support combination of any Univariate distributions with specified probabilities.

The new implementation knows to combine analytically discrete and normal distributions.

Fixes #3105

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten GuySten marked this pull request as ready for review June 16, 2025 16:17
@GuySten GuySten requested review from pshriwise and shimwell August 12, 2025 03:52
@GuySten GuySten added the Bugs label Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

probs arg ignored if openmc.stats.Normal passed to openmc.stats.combine_distributions

1 participant