Skip to content

add(patches): Drop babel from getting pulled in by node-environment #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 5, 2025

Conversation

sommeeeer
Copy link
Contributor

Closes #947

I applied it on >=15.0.0.

Copy link

changeset-bot bot commented Aug 4, 2025

🦋 Changeset detected

Latest commit: 6879b38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Aug 4, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@948

commit: 6879b38

@sommeeeer
Copy link
Contributor Author

cc @vicb

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm with one comment.
Thanks!

@sommeeeer
Copy link
Contributor Author

Thanks for the review Victor!

@sommeeeer sommeeeer requested a review from vicb August 5, 2025 07:26
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it 🚀
Thanks!

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!!

@conico974 conico974 merged commit 042dfd9 into opennextjs:main Aug 5, 2025
3 checks passed
@github-actions github-actions bot mentioned this pull request Aug 5, 2025
@sommeeeer sommeeeer deleted the fix-remove-babel branch August 5, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream babel drop patch
3 participants