-
Notifications
You must be signed in to change notification settings - Fork 168
add(patches): Drop babel from getting pulled in by node-environment #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 6879b38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
cc @vicb |
packages/tests-unit/tests/build/patch/patches/patchNodeEnvironment.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm with one comment.
Thanks!
Thanks for the review Victor! |
packages/open-next/src/build/patch/patches/patchNodeEnvironment.ts
Outdated
Show resolved
Hide resolved
…t.ts Co-authored-by: Victor Berchet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it 🚀
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!!
Closes #947
I applied it on
>=15.0.0
.