Skip to content

enable e2e/pages-router tests to run in CI #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Feb 3, 2025

this change renames the e2e script of the e2e/pages-router app to just e2e so that it is included as part of our CI checks, in order for it not to fail one test has been skipped (with an appropriate comment explain why)


related to #291

this change renames the `e2e` script of the `e2e/pages-router` app
to just `e2e` so that it is included as part of our CI checks, in
order for it not to fail one test has been skipped (with an
appropriate comment explain why)
@dario-piotrowicz dario-piotrowicz requested a review from vicb February 3, 2025 16:43
Copy link

changeset-bot bot commented Feb 3, 2025

⚠️ No Changeset found

Latest commit: 8e74909

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Feb 3, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@332

commit: 8e74909

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks Dario!

@vicb
Copy link
Contributor

vicb commented Feb 3, 2025

@dario-piotrowicz I edited to description to rewrite fixes 291 to related to 291 as there is more in there, does that make sense?

@dario-piotrowicz
Copy link
Contributor Author

@dario-piotrowicz I edited to description to rewrite fixes 291 to related to 291 as there is more in there, does that make sense?

ah yeah sorry I was closing it as all the e2es are not being run, and we do have the extra sub-issues to deal with

yeah given that the remaining ones are sub-issues I guess it does make sense to keep the parent issue open 👍

@vicb
Copy link
Contributor

vicb commented Feb 3, 2025

@dario-piotrowicz I edited to description to rewrite fixes 291 to related to 291 as there is more in there, does that make sense?

ah yeah sorry I was closing it as all the e2es are not being run, and we do have the extra sub-issues to deal with

yeah given that the remaining ones are sub-issues I guess it does make sense to keep the parent issue open 👍

I don't think the build issue has been tackled?

(You can update the parent issue with a status)

Thanks

@dario-piotrowicz dario-piotrowicz merged commit e2918eb into main Feb 3, 2025
7 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/pages-router/e2e-fix branch February 3, 2025 18:16
dario-piotrowicz added a commit that referenced this pull request Feb 4, 2025
in #332 the destination
for the `/external-on-image` was rewritten not to point to an asset hosted on
the Cloudflare network, revert such change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants