-
Notifications
You must be signed in to change notification settings - Fork 46
enable e2e/pages-router tests to run in CI #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this change renames the `e2e` script of the `e2e/pages-router` app to just `e2e` so that it is included as part of our CI checks, in order for it not to fail one test has been skipped (with an appropriate comment explain why)
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks Dario!
@dario-piotrowicz I edited to description to rewrite |
ah yeah sorry I was closing it as all the e2es are not being run, and we do have the extra sub-issues to deal with yeah given that the remaining ones are sub-issues I guess it does make sense to keep the parent issue open 👍 |
I don't think the build issue has been tackled? (You can update the parent issue with a status) Thanks |
in #332 the destination for the `/external-on-image` was rewritten not to point to an asset hosted on the Cloudflare network, revert such change
this change renames the
e2e
script of thee2e/pages-router
app to juste2e
so that it is included as part of our CI checks, in order for it not to fail one test has been skipped (with an appropriate comment explain why)related to #291