feat: reused responses demo #1517
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for netlify-plugin-nextjs-demo pending review.Visit the deploys page to approve it
|
👷 Deploy request for netlify-plugin-nextjs-next-auth-demo pending review.Visit the deploys page to approve it
|
👷 Deploy request for netlify-plugin-nextjs-static-root-demo pending review.Visit the deploys page to approve it
|
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 5f561cc |
👷 Deploy request for next-hp-edge-demo pending review.Visit the deploys page to approve it
|
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 5f561cc |
👷 Deploy request for netlify-plugin-nextjs-nx-monorepo-demo pending review.Visit the deploys page to approve it
|
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 5f561cc |
👷 Deploy request for next-i18next-demo pending review.Visit the deploys page to approve it
|
👷 Deploy request for netlify-plugin-nextjs-export-demo pending review.Visit the deploys page to approve it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a demo that reuses data fetched during getStaticPaths() in getStaticProps() as originally discussed here and demonstrated here. It should be helpful to test against after this issue is solved. I also included a small typo fix I noticed in one of the integration tests.
Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
vercel/next.js#11272
https://github.com/vercel/examples/tree/main/solutions/reuse-responses
#1179
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.