Skip to content

fix: correct root redirect when trailingSlash = false #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2021
Merged

fix: correct root redirect when trailingSlash = false #879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3ccffc
fix: correct root redirect when trailingSlash = false
ascorbic Dec 3, 2021
a81bc68
Merge branch 'main' into mk/redirect-i18n-slash
kodiakhq[bot] Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/helpers/redirects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const generateLocaleRedirects = ({
const redirects: NetlifyConfig['redirects'] = []
// If the cookie is set, we need to redirect at the origin
redirects.push({
from: `${basePath}${trailingSlash ? '/' : ''}`,
from: `${basePath}/`,
to: HANDLER_FUNCTION_PATH,
status: 200,
force: true,
Expand All @@ -32,7 +32,7 @@ const generateLocaleRedirects = ({
}
redirects.push({
from: `${basePath}/`,
to: `${basePath}/${locale}/`,
to: `${basePath}/${locale}${trailingSlash ? '/' : ''}`,
status: 301,
conditions: {
Language: [locale],
Expand Down