set_rotate

[viperet]

Hi! I've a new dirrective set_rotate $value $from $to, which "rotates" $value in range $from - $to
Sample config:

   location /rotate {
       default_type text/plain;
       set $counter $cookie_counter;
       set_rotate $counter 1 5;
       echo $counter;
       add_header Set-Cookie counter=$counter;
   }                                                                                                      

Accessing "/rotate" will display numbers from 1 to 5 in cycle. I use this directive for rotating banners.
I've added some basic documentation to doc/HttpSetMiscModule.wiki

[agentzh]

This looks very interesting :) I'll merge your patches later when I have some time ;) Thank you for your contribution!

[agentzh]

Sorry for the delay! It seems to me that another interesting feature here is when $counter is uninitialized, i.e., not found or just empty strings, then we could use a persistent state in the nginx worker process level, such that we can do round-robin dispatch for upstreams.

Also, will you submit some test cases for this new feature?

Thank you!

[agentzh]

No worries, I'm already working on these :)

[agentzh]

I've fixed various coding style issues and typos in your patches:

https://github.com/agentzh/set-misc-nginx-module/commit/9e061396

I've also added some test cases for this new directive.

I'll then work on the persistent rotating state for this directive when there is no "current value" given.

[agentzh]

I've already made the "current value" persistent and set_rotate will use it when the current value is not given or is given a bad value. See the patch here:

https://github.com/agentzh/set-misc-nginx-module/commit/9792e8d

Does it look good for you?

[agentzh]

The "current value" persistence is also on a per-location basis, see the following (passing) test case:

1c8e3ef

[viperet]

Thanks for correcting and fixing my code.

Does it look good for you?

It's very good to me!