Fix bug in ResolvedPom#mergeDependencyManagement()
#5529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The merging of managed dependency properties was not quite correct in `ResolvedPom`. I didn't find an easy way to fix it, so the changes are a bit more exhaustive than I was hoping for. Additionally, the `dependencyManagement` list is now sorted, so that the `getManagedXyz()` operations are faster.
knutwannheden
commented
May 30, 2025
rewrite-maven/src/main/java/org/openrewrite/maven/tree/ResolvedPom.java
Outdated
Show resolved
Hide resolved
sambsnyd
reviewed
May 30, 2025
rewrite-maven/src/test/java/org/openrewrite/maven/ExcludeDependencyTest.java
Outdated
Show resolved
Hide resolved
rewrite-maven/src/main/java/org/openrewrite/maven/tree/ResolvedPom.java
Outdated
Show resolved
Hide resolved
This was referenced Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merging of managed dependency properties was not quite correct in
ResolvedPom. I didn't find an easy way to fix it, so the changes are a bit more exhaustive than I was hoping for.Additionally, the
dependencyManagementlist is now sorted (using TimSort 😄), so that thegetManagedXyz()operations are faster.