Skip to content

[release-1.36] Run make generated-files #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

serverless-qe
Copy link
Contributor

Generated by running make generated-files

@openshift-ci openshift-ci bot requested review from dsimansk and skonto May 13, 2025 07:04
@serverless-qe serverless-qe force-pushed the auto/update-generated-files-release-1.36 branch from 49c65ed to 6d613c3 Compare May 16, 2025 08:01
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold

@serverless-qe serverless-qe force-pushed the auto/update-generated-files-release-1.36 branch from 6d613c3 to f9715ca Compare May 19, 2025 11:55
@openshift-ci openshift-ci bot removed the lgtm label May 19, 2025
@serverless-qe serverless-qe force-pushed the auto/update-generated-files-release-1.36 branch from f9715ca to 484cd12 Compare May 19, 2025 13:42
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we have theses changes on the knative kafka controller resources, I think we need to get these changes in the next bundle (@rudyredhat1 @Kaustubh-pande fyi)

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/ok-to-test

Copy link
Contributor

openshift-ci bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew, serverless-qe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Member

creydr commented May 19, 2025

/retest-required

1 similar comment
@Kaustubh-pande
Copy link
Contributor

/retest-required

@creydr
Copy link
Member

creydr commented May 19, 2025

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit cb92ee8 into release-1.36 May 19, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants