Skip to content

feat: make the observers asynchronous #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ziccardi
Copy link
Contributor

Observers are currently synchronous: a slow observer would slow down the whole routine manager.
This PR makes the observers asynchronous

@tzvatot
Copy link
Contributor

tzvatot commented Jun 3, 2025

Couple of thoughts:

  1. We don't nervelessly have a requirement to run the observers async. While in some cases it make sense, and has value, the consumer of the framework can achieve that by creating a top level observer, that will notify a set of child-observers asynchronously. So I'm contemplating between keeping the framework simple and yet expandable, than introducing a level of complexity that we don't necessarily need, which also adds some risk.
  2. This PR does not have any tests attached. Given #1, maybe that is not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants