Skip to content

OTA-1339: Add UpdateStatusAPI FG for DevPreview #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

petr-muller
Copy link
Member

OTA originally created and used the UpgradeStatus legacy feature gate for the related functionality, enabled in TechPreview. Moving the functionality into the cluster, exposed by an API proved to be more complex and experimental than thought, so it was decided to create and use a new feature gate that is only enabled in DevPreview.

xref: #2233

OTA originally created and used the UpgradeStatus legacy feature gate for the related functionality, enabled in TechPreview. Moving the functionality into the cluster, exposed by an API proved to be more complex and experimental than thought, so it was decided to create and use a new feature gate that is only enabled in DevPreview.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 21, 2025

@petr-muller: This pull request references OTA-1339 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

OTA originally created and used the UpgradeStatus legacy feature gate for the related functionality, enabled in TechPreview. Moving the functionality into the cluster, exposed by an API proved to be more complex and experimental than thought, so it was decided to create and use a new feature gate that is only enabled in DevPreview.

xref: #2233

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

Hello @petr-muller! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2025
@openshift-ci openshift-ci bot requested review from deads2k and JoelSpeed March 21, 2025 15:35
Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-muller
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-muller
Copy link
Member Author

/retest

Copy link
Contributor

openshift-ci bot commented Apr 12, 2025

@petr-muller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-out-of-change 95a6664 link true /test e2e-upgrade-out-of-change
ci/prow/e2e-aws-serial-techpreview 95a6664 link true /test e2e-aws-serial-techpreview
ci/prow/verify-client-go 95a6664 link true /test verify-client-go
ci/prow/e2e-aws-ovn 95a6664 link true /test e2e-aws-ovn
ci/prow/e2e-aws-serial 95a6664 link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn-techpreview 95a6664 link true /test e2e-aws-ovn-techpreview
ci/prow/minor-e2e-upgrade-minor 95a6664 link true /test minor-e2e-upgrade-minor
ci/prow/e2e-aws-ovn-hypershift 95a6664 link true /test e2e-aws-ovn-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@petr-muller
Copy link
Member Author

petr-muller commented Apr 14, 2025

/hold
/shrug

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ labels Apr 14, 2025
@petr-muller
Copy link
Member Author

/close

Proposal was rejected internally

@openshift-ci openshift-ci bot closed this Apr 16, 2025
Copy link
Contributor

openshift-ci bot commented Apr 16, 2025

@petr-muller: Closed this PR.

In response to this:

/close

Proposal was rejected internally

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants