Skip to content

SPLAT-2213: Added vSphere mixed node env feature gate #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

SPLAT-2213: Added vSphere mixed node env feature gate #2326

merged 1 commit into from
May 19, 2025

Conversation

vr4manta
Copy link
Contributor

SPLAT-2213

Changes

  • Created new feature gate for vSphere mixed node env feature

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 16, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2213 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

SPLAT-2213

Changes

  • Created new feature gate for vSphere mixed node env feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2025

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 16, 2025
@openshift-ci openshift-ci bot requested review from everettraven and JoelSpeed May 16, 2025 14:18
@rvanderp3
Copy link
Contributor

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2025
@vr4manta
Copy link
Contributor Author

/assign @JoelSpeed

JoelSpeed
JoelSpeed reviewed May 19, 2025
View reviewed changes
features/features.go
reportProblemsToJiraComponent("splat").
contactPerson("vr4manta").
productScope(ocpSpecific).
enhancementPR("https://github.com/openshift/enhancements/pull/1772").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This EP is closed?

Copy link
Contributor Author

@vr4manta vr4manta May 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll refresh it. This is the one we currently have. It went stale.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-opened the PR and removed rotten label. I'll be updating this doc this week with more of my findings of what we need to address.

@vr4manta vr4manta mentioned this pull request May 19, 2025
Open
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, rvanderp3, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9cbdb71 and 2 for PR HEAD 072c8ad in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 19, 2025

@vr4manta: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#305
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2e311ff0-34e2-11f0-8e4b-8c6339c6e858-0

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 19, 2025

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 768a119 into openshift:master May 19, 2025
26 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202505200057.p0.g768a119.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@everettraven everettraven Awaiting requested review from everettraven

Assignees

@JoelSpeed JoelSpeed

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vr4manta @openshift-ci-robot @rvanderp3 @JoelSpeed @openshift-bot