[CCXDEV-15259]: promote InsightConfigAPI and OnDemandDataGather to v1 #2448

opokornyy · 2025-08-12T14:22:09Z

No description provided.

openshift-ci · 2025-08-12T14:22:17Z

Hello @opokornyy! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

opokornyy · 2025-08-12T14:30:29Z

/retest

opokornyy · 2025-08-14T07:04:57Z

/test verify-feature-promotion

config/v1/types_insights.go

Signed-off-by: Ondrej Pokorny <[email protected]>

config/v1/types_insights.go

Signed-off-by: Ondrej Pokorny <[email protected]>

insights/v1/types_insights.go

opokornyy · 2025-09-02T07:31:11Z

/retest

config/v1/types_insights.go

Signed-off-by: Ondrej Pokorny <[email protected]>

opokornyy · 2025-09-09T07:23:01Z

/retest

everettraven · 2025-09-09T12:40:18Z

@opokornyy Is this still WIP? If not, would you mind dropping the WIP: from the title?

opokornyy · 2025-09-10T07:55:40Z

/retest

opokornyy · 2025-09-10T07:59:48Z

@opokornyy Is this still WIP? If not, would you mind dropping the WIP: from the title?

Sure, I forgot to drop that. Should I still keep it as a draft as well?

everettraven · 2025-09-10T11:50:12Z

Sure, I forgot to drop that. Should I still keep it as a draft as well?

If you think this is ready to review for merge, it should not be a draft. If this is something you don't yet want reviews on a draft is appropriate.

opokornyy · 2025-09-10T12:31:44Z

/retest

JoelSpeed

Have done a more thorough review today of the text and godoc, if you can apply my suggestions, I think we are ready to merge this.

Do we have a feature promotion PR that accompanies this to show what the feature promotion data might look like?

config/v1/types_insights.go

JoelSpeed · 2025-09-11T14:28:40Z

/approve

/hold for @everettraven in case he has any further comments

everettraven

A couple comments

config/v1/types_insights.go

everettraven · 2025-09-11T15:01:45Z

With agreement from Joel on the status subresource removal, once the changes from my review are made this LGTM

JoelSpeed · 2025-09-11T15:12:08Z

/approve cancel

Realised I missed the second set of types being promoted on my last review

everettraven · 2025-09-11T18:54:49Z

Realised I missed the second set of types being promoted on my last review

Ah, I missed this as well 🤦

everettraven

A couple more comments from the types I missed on my last review round

insights/v1/types_insights.go

everettraven · 2025-09-11T19:02:22Z

insights/v1/types_insights.go

+	// When omitted, this means no data gathering has taken place yet or the
+	// corresponding Insights analysis (identified by "insightsRequestID") is not available.
+	// +optional
+	InsightsReport *InsightsReport `json:"insightsReport,omitempty"`


Is there a semantic difference between insightsReport: {} and it being omitted?

I think there is no difference. Should I change this field somehow?

You'll need to remove the pointer and add the omitzero tag.

In order to do that, you'll need to update the InsightsReport type to require some sub-field being specified.

Does it ever make sense for the InsightsReport type to only contain a subset of the fields allowed in its type?

Our operator is setting this field and I think we can make the downloadedTime and uri required, because we are always setting these two fields and healthChecks would be the only optional field here.

insights/v1/types_insights.go

openshift-ci · 2025-09-16T08:57:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

opokornyy · 2025-09-17T08:59:51Z

Hey, I think I’ve addressed all the comments, so it should be ready for another round of reviews. @JoelSpeed @everettraven

everettraven

A couple more godoc only comments.

Other than that, this looks fine to me.

insights/v1/types_insights.go

insights/v1/tests/datagathers.insights.openshift.io/InsightsOnDemandDataGather.yaml

opokornyy · 2025-09-19T07:35:44Z

/retest

insights/v1/types_insights.go

Signed-off-by: Ondrej Pokorny <[email protected]>

openshift-ci · 2025-09-22T11:20:17Z

@opokornyy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-serial-techpreview-1of2	`4a43f0f`	link	true	`/test e2e-aws-serial-techpreview-1of2`
ci/prow/e2e-gcp	`4a43f0f`	link	false	`/test e2e-gcp`
ci/prow/e2e-aws-ovn-techpreview	`4a43f0f`	link	true	`/test e2e-aws-ovn-techpreview`
ci/prow/e2e-aws-ovn	`4a43f0f`	link	true	`/test e2e-aws-ovn`
ci/prow/e2e-aws-ovn-hypershift	`4a43f0f`	link	true	`/test e2e-aws-ovn-hypershift`
ci/prow/e2e-aws-serial-techpreview-2of2	`4a43f0f`	link	true	`/test e2e-aws-serial-techpreview-2of2`
ci/prow/okd-scos-e2e-aws-ovn	`25581c4`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/minor-e2e-upgrade-minor	`25581c4`	link	true	`/test minor-e2e-upgrade-minor`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

opokornyy · 2025-09-24T13:28:15Z

Hey @JoelSpeed, @everettraven all comments should be resolved now.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2025

openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 12, 2025

openshift-ci bot requested review from deads2k and everettraven August 12, 2025 14:24

opokornyy force-pushed the CCXDEV-15259-io-v1 branch 2 times, most recently from d7b46b0 to dce787e Compare August 15, 2025 09:48

opokornyy changed the title ~~WIP: promote InsightConfigAPI and OnDemandDataGather to v1~~ WIP: [CCXDEV-15259]: promote InsightConfigAPI and OnDemandDataGather to v1 Aug 15, 2025

opokornyy force-pushed the CCXDEV-15259-io-v1 branch from dce787e to 337fbf2 Compare August 18, 2025 07:49

JoelSpeed reviewed Aug 18, 2025

View reviewed changes

config/v1/types_insights.go Outdated Show resolved Hide resolved

config/v1/types_insights.go Outdated Show resolved Hide resolved

config/v1/types_insights.go Outdated Show resolved Hide resolved

config/v1/types_insights.go Outdated Show resolved Hide resolved

opokornyy force-pushed the CCXDEV-15259-io-v1 branch 2 times, most recently from 382e32d to c47f3e9 Compare August 19, 2025 08:08

opokornyy added 4 commits August 19, 2025 15:10

feat(insights): add v1 version

c01c100

Signed-off-by: Ondrej Pokorny <[email protected]>

feat(config): add v1 version for insights config

3b94abc

Signed-off-by: Ondrej Pokorny <[email protected]>

fix: linter errors

abc890b

Signed-off-by: Ondrej Pokorny <[email protected]>

fix: integration tests

502bf0a

Signed-off-by: Ondrej Pokorny <[email protected]>

everettraven reviewed Aug 19, 2025

View reviewed changes

config/v1/types_insights.go Show resolved Hide resolved

fix: dataPolicy linter error

d29ee57

Signed-off-by: Ondrej Pokorny <[email protected]>

opokornyy force-pushed the CCXDEV-15259-io-v1 branch from c47f3e9 to d29ee57 Compare August 29, 2025 13:02

opokornyy commented Sep 1, 2025

View reviewed changes

insights/v1/types_insights.go Outdated Show resolved Hide resolved

opokornyy force-pushed the CCXDEV-15259-io-v1 branch from a2b2dec to e34bacd Compare September 1, 2025 11:25

JoelSpeed reviewed Sep 2, 2025

View reviewed changes

config/v1/types_insights.go Outdated Show resolved Hide resolved

config/v1/types_insights.go Outdated Show resolved Hide resolved

config/v1/types_insights.go Show resolved Hide resolved

opokornyy force-pushed the CCXDEV-15259-io-v1 branch from e34bacd to c3bd449 Compare September 8, 2025 10:11

fix: totalRisk and group fields

43fc93f

Signed-off-by: Ondrej Pokorny <[email protected]>

opokornyy force-pushed the CCXDEV-15259-io-v1 branch from c3bd449 to 43fc93f Compare September 8, 2025 13:29

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2025

JoelSpeed reviewed Sep 11, 2025

View reviewed changes

opokornyy force-pushed the CCXDEV-15259-io-v1 branch from cf53f5d to 4a43f0f Compare September 11, 2025 13:40

openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 11, 2025

everettraven reviewed Sep 11, 2025

View reviewed changes

config/v1/types_insights.go Outdated Show resolved Hide resolved

config/v1/types_insights.go Outdated Show resolved Hide resolved

openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2025

everettraven reviewed Sep 11, 2025

View reviewed changes

JoelSpeed reviewed Sep 12, 2025

View reviewed changes

opokornyy force-pushed the CCXDEV-15259-io-v1 branch from 4a43f0f to 654c441 Compare September 16, 2025 08:56

opokornyy force-pushed the CCXDEV-15259-io-v1 branch from 654c441 to fc30ba4 Compare September 16, 2025 09:25

everettraven reviewed Sep 17, 2025

View reviewed changes

insights/v1/types_insights.go Outdated Show resolved Hide resolved

insights/v1/types_insights.go Outdated Show resolved Hide resolved

JoelSpeed reviewed Sep 17, 2025

View reviewed changes

insights/v1/tests/datagathers.insights.openshift.io/InsightsOnDemandDataGather.yaml Outdated Show resolved Hide resolved

opokornyy force-pushed the CCXDEV-15259-io-v1 branch from fc30ba4 to 596ed30 Compare September 18, 2025 13:00

JoelSpeed reviewed Sep 19, 2025

View reviewed changes

insights/v1/types_insights.go Outdated Show resolved Hide resolved

insights/v1/types_insights.go Outdated Show resolved Hide resolved

feat: address review comments

25581c4

Signed-off-by: Ondrej Pokorny <[email protected]>

opokornyy force-pushed the CCXDEV-15259-io-v1 branch from 596ed30 to 25581c4 Compare September 22, 2025 07:18

[CCXDEV-15259]: promote InsightConfigAPI and OnDemandDataGather to v1 #2448

Are you sure you want to change the base?

[CCXDEV-15259]: promote InsightConfigAPI and OnDemandDataGather to v1 #2448

Uh oh!

Conversation

opokornyy commented Aug 12, 2025

Uh oh!

openshift-ci bot commented Aug 12, 2025

Uh oh!

opokornyy commented Aug 12, 2025

Uh oh!

opokornyy commented Aug 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

opokornyy commented Sep 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

opokornyy commented Sep 9, 2025

Uh oh!

everettraven commented Sep 9, 2025

Uh oh!

opokornyy commented Sep 10, 2025

Uh oh!

opokornyy commented Sep 10, 2025

Uh oh!

everettraven commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

opokornyy commented Sep 10, 2025

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoelSpeed commented Sep 11, 2025

Uh oh!

everettraven left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

everettraven commented Sep 11, 2025

Uh oh!

JoelSpeed commented Sep 11, 2025

Uh oh!

everettraven commented Sep 11, 2025

Uh oh!

everettraven left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

everettraven Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

opokornyy Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

everettraven Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

opokornyy Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

everettraven commented Sep 10, 2025 •

edited

Loading