Skip to content

MON-4029: Add KubeStateMetrics api #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MON-4029: Add KubeStateMetrics api #2461

wants to merge 2 commits into from

Conversation

marioferh
Copy link
Contributor

after: #2322

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 29, 2025

Hello @marioferh! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 29, 2025
@marioferh
Copy link
Contributor Author

/retest-required

everettraven
everettraven reviewed Sep 3, 2025
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual API for KSM changes seem straightforward and look fine to me.

I noticed there are no integration tests in place. Can we add some simple ones to make sure things like .spec.kubeStateMetricsConfig: {} isn't valid and help us catch any potential regressions from changes in the future?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2025
@marioferh marioferh force-pushed the kube_state_metrics_api branch from 5075163 to e16b37e Compare September 16, 2025 08:50
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2025
@marioferh
Copy link
Contributor Author

Actual API for KSM changes seem straightforward and look fine to me.

I noticed there are no integration tests in place. Can we add some simple ones to make sure things like .spec.kubeStateMetricsConfig: {} isn't valid and help us catch any potential regressions from changes in the future?

done

@marioferh
KubeStateMetrics api
74d9f80 
Signed-off-by: Mario Fernandez <[email protected]>
@marioferh marioferh force-pushed the kube_state_metrics_api branch from e16b37e to 74d9f80 Compare September 16, 2025 09:29
@everettraven
Copy link
Contributor

/assign

everettraven
everettraven reviewed Sep 17, 2025
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor comments, but other than those this LGTM

@everettraven everettraven mentioned this pull request Sep 17, 2025
Open
@marioferh
add suggestions
cc552d8 
Signed-off-by: Mario Fernandez <[email protected]>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from everettraven. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 17, 2025

@marioferh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview-2of2 1b8a123 link true /test e2e-aws-serial-techpreview-2of2
ci/prow/minor-e2e-upgrade-minor cc552d8 link true /test minor-e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

everettraven
everettraven reviewed Sep 18, 2025
View reviewed changes
config/v1alpha1/types_cluster_monitoring.go
Comment on lines +486 to +487
// Minimum number of properties: 1.
// Maximum number of properties: 10.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common OpenShift terminology please.

everettraven
everettraven reviewed Sep 18, 2025
View reviewed changes
config/v1alpha1/types_cluster_monitoring.go
// When omitted, this means the user has no opinion and the platform is left
// to choose reasonable defaults. These defaults are subject to change over time.
// Defaults are empty/unset.
// When specified, resources must contain at least 1 entry and must not contain more than 10 entries.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// When specified, resources must contain at least 1 entry and must not contain more than 10 entries.
// When specified, tolerations must contain at least 1 entry and must not contain more than 10 entries.

everettraven
everettraven reviewed Sep 18, 2025
View reviewed changes
config/v1alpha1/types_cluster_monitoring.go
// When omitted, this means no opinion and the platform is left to choose a default, which is subject to change over time.
// This field maps directly to the `topologySpreadConstraints` field in the Pod spec.
// Default is empty list.
// When specified, resources must contain at least 1 entry and must not contain more than 10 entries.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// When specified, resources must contain at least 1 entry and must not contain more than 10 entries.
// When specified, topologySpreadConstraints must contain at least 1 entry and must not contain more than 10 entries.

@marioferh marioferh changed the title Monitoring API: Add KubeStateMetrics api MON-4029: Add KubeStateMetrics api Sep 23, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2025 •
edited by openshift-ci bot
Loading

@marioferh: This pull request references MON-4029 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

after: #2322

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

1 more reviewer

@everettraven everettraven everettraven left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@everettraven everettraven

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marioferh @everettraven @openshift-ci-robot @openshift-merge-robot