Skip to content

OCPBUGS-61689: Add 'AGE' print column to MachineConfigNode object #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

OCPBUGS-61689: Add 'AGE' print column to MachineConfigNode object #2476

merged 1 commit into from
Sep 19, 2025

Conversation

isabella-janssen
Copy link
Member

@isabella-janssen isabella-janssen commented Sep 12, 2025 •
edited
Loading

This adds a column called AGE to the output for the MachineConfigNode object.

To test:

  1. Launch a 4.21 cluster with this PR.
  2. Observe the MCN output.
$ oc get machineconfignode
NAME                                       POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   AGE
ci-ln-dks5l4k-72292-vt5jm-master-0         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m
ci-ln-dks5l4k-72292-vt5jm-master-1         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m
ci-ln-dks5l4k-72292-vt5jm-master-2         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m
ci-ln-dks5l4k-72292-vt5jm-worker-a-2fgj4   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      40m
ci-ln-dks5l4k-72292-vt5jm-worker-b-lm488   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      38m
ci-ln-dks5l4k-72292-vt5jm-worker-c-lnq7c   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      40m

$ oc get machineconfignode -o wide
NAME                                       POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   AGE   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ci-ln-dks5l4k-72292-vt5jm-master-0         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-master-1         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-master-2         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-worker-a-2fgj4   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      40m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-worker-b-lm488   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      38m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-worker-c-lnq7c   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      40m   False            False            False                      False            False     False               False          False         False          False

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

Hello @isabella-janssen! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 12, 2025
@openshift-ci-robot
Copy link

@isabella-janssen: This pull request references Jira Issue OCPBUGS-61689, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr September 12, 2025 18:04
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 12, 2025
@openshift-ci-robot
Copy link

@isabella-janssen: This pull request references Jira Issue OCPBUGS-61689, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

This adds a column called AGE to the output for the MachineConfigNode object.

To test:

  1. Launch a 4.21 cluster with this PR.
  2. Observe the MCN output.
$ oc get machineconfignode
NAME                                       POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   AGE
ci-ln-dks5l4k-72292-vt5jm-master-0         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m
ci-ln-dks5l4k-72292-vt5jm-master-1         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m
ci-ln-dks5l4k-72292-vt5jm-master-2         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m
ci-ln-dks5l4k-72292-vt5jm-worker-a-2fgj4   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      40m
ci-ln-dks5l4k-72292-vt5jm-worker-b-lm488   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      38m
ci-ln-dks5l4k-72292-vt5jm-worker-c-lnq7c   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      40m

$ oc get machineconfignode -o wide
NAME                                       POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   AGE   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ci-ln-dks5l4k-72292-vt5jm-master-0         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-master-1         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-master-2         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-worker-a-2fgj4   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      40m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-worker-b-lm488   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      38m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-worker-c-lnq7c   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      40m   False            False            False                      False            False     False               False          False         False          False

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen isabella-janssen marked this pull request as ready for review September 12, 2025 19:39
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2025
@JoelSpeed
Copy link
Contributor

Seems to be an issue with the verify, PTAL, otherwise LGTM

yuqi-zhang
yuqi-zhang approved these changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

from the MCO side, thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2025
@isabella-janssen
Copy link
Member Author

/test verify

@JoelSpeed
Copy link
Contributor

/approve

@isabella-janssen I'll leave the verified label to you

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2025
@isabella-janssen
Copy link
Member Author

/test e2e-aws-ovn-hypershift

@JoelSpeed
Copy link
Contributor

@isabella-janssen Have you verified this behavioural change yourself? Happy to add the verified label?

@isabella-janssen
Copy link
Member Author

@JoelSpeed I have verified on my own, but @ptalgulk01 is planning to do additional pre-merge verification before applying the verified label.

@ptalgulk01
Copy link

Pre-merge verified:

Verified on IPI based GCP cluster.

launch 4.21,openshift/machine-config-operator#2476 gcp
  • Able to see the new changes
$ oc get machineconfignode -o wide
NAME                                       POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   AGE   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ci-ln-zjdw97t-72292-t6tr6-master-0         master     rendered-master-e0aac7ec8cb264c885096a39af123c87   rendered-master-e0aac7ec8cb264c885096a39af123c87   True      33m   False            False            False                      False            False     False               False          False         False          False
ci-ln-zjdw97t-72292-t6tr6-master-1         master     rendered-master-e0aac7ec8cb264c885096a39af123c87   rendered-master-e0aac7ec8cb264c885096a39af123c87   True      33m   False            False            False                      False            False     False               False          False         False          False
ci-ln-zjdw97t-72292-t6tr6-master-2         master     rendered-master-e0aac7ec8cb264c885096a39af123c87   rendered-master-e0aac7ec8cb264c885096a39af123c87   True      33m   False            False            False                      False            False     False               False          False         False          False
ci-ln-zjdw97t-72292-t6tr6-worker-a-mr8zn   worker     rendered-worker-04d071dd417eb20100ad275e67283d2d   rendered-worker-04d071dd417eb20100ad275e67283d2d   True      21m   False            False            False                      False            False     False               False          False         False          False
ci-ln-zjdw97t-72292-t6tr6-worker-b-nqp48   worker     rendered-worker-04d071dd417eb20100ad275e67283d2d   rendered-worker-04d071dd417eb20100ad275e67283d2d   True      21m   False            False            False                      False            False     False               False          False         False          False
ci-ln-zjdw97t-72292-t6tr6-worker-c-vj8xh   worker     rendered-worker-04d071dd417eb20100ad275e67283d2d   rendered-worker-04d071dd417eb20100ad275e67283d2d   True      21m   False            False            False                      False            False     False               False          False         False          False

Also tested on existing e2e MCN testcases no issue seen
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 18, 2025
@ptalgulk01
Copy link

/verified by @ptalgulk01

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 18, 2025
@openshift-ci-robot
Copy link

@ptalgulk01: This PR has been marked as verified by @ptalgulk01.

In response to this:

/verified by @ptalgulk01

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member Author

/cherrypick release-4.20 release-4.19

@openshift-cherrypick-robot
Copy link

@isabella-janssen: once the present PR merges, I will cherry-pick it on top of release-4.20 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.20 release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 83b017b and 2 for PR HEAD 21152db in total

@isabella-janssen
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 83b017b and 2 for PR HEAD 21152db in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 83b017b and 2 for PR HEAD 21152db in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a966b57 and 2 for PR HEAD 21152db in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 19, 2025

@isabella-janssen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 588d549 into openshift:master Sep 19, 2025
27 checks passed
@openshift-ci-robot
Copy link

@isabella-janssen: Jira Issue Verification Checks: Jira Issue OCPBUGS-61689
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-61689 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

This adds a column called AGE to the output for the MachineConfigNode object.

To test:

  1. Launch a 4.21 cluster with this PR.
  2. Observe the MCN output.
$ oc get machineconfignode
NAME                                       POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   AGE
ci-ln-dks5l4k-72292-vt5jm-master-0         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m
ci-ln-dks5l4k-72292-vt5jm-master-1         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m
ci-ln-dks5l4k-72292-vt5jm-master-2         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m
ci-ln-dks5l4k-72292-vt5jm-worker-a-2fgj4   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      40m
ci-ln-dks5l4k-72292-vt5jm-worker-b-lm488   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      38m
ci-ln-dks5l4k-72292-vt5jm-worker-c-lnq7c   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      40m

$ oc get machineconfignode -o wide
NAME                                       POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   AGE   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ci-ln-dks5l4k-72292-vt5jm-master-0         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-master-1         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-master-2         master     rendered-master-3b21be93539ffce4a129bbe5103468d6   rendered-master-3b21be93539ffce4a129bbe5103468d6   True      49m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-worker-a-2fgj4   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      40m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-worker-b-lm488   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      38m   False            False            False                      False            False     False               False          False         False          False
ci-ln-dks5l4k-72292-vt5jm-worker-c-lnq7c   worker     rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   rendered-worker-62179dfd7b67de8687d742eb75a8e6f0   True      40m   False            False            False                      False            False     False               False          False         False          False

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@isabella-janssen: new pull request created: #2486

In response to this:

/cherrypick release-4.20 release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 19, 2025
Closed
@isabella-janssen isabella-janssen deleted the ocpbugs-61689 branch September 19, 2025 17:41
@isabella-janssen isabella-janssen mentioned this pull request Sep 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

1 more reviewer

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yuqi-zhang yuqi-zhang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@isabella-janssen @openshift-ci-robot @JoelSpeed @ptalgulk01 @openshift-cherrypick-robot @yuqi-zhang