Skip to content

Conversation

ShazaAldawamneh
Copy link

No description provided.

Signed-off-by: Shaza Aldawamneh <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2025
Copy link
Contributor

openshift-ci bot commented Sep 19, 2025

Hello @ShazaAldawamneh! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@ShazaAldawamneh ShazaAldawamneh changed the title [WIP]: adding auth config missing fields to API [WIP]: CNTRLPLANE-311: adding auth config missing fields to API Sep 19, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2025

@ShazaAldawamneh: This pull request references CNTRLPLANE-311 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 19, 2025
Copy link
Contributor

openshift-ci bot commented Sep 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Shaza Aldawamneh <[email protected]>
prefixPolicy: Prefix
prefix:
prefixString: "myoidc:"
expectedError: "spec.oidcProviders[0].issuer.discoveryURL: Invalid value: \"not-a-valid-url\": discoveryURL must not contain user info"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is an incorrect expected error.

It looks like the tests are expecting this to be:

spec.oidcProviders[0].issuer.discoveryURL: Invalid value: "string": discoveryURL must be a valid URL, spec.oidcProviders[0].issuer.discoveryURL: Invalid value: "string": discoveryURL must be a valid https URL

This looks like it is triggering multiple validation errors, which means you likely need to account for that in your expected error here.

Copy link
Contributor

openshift-ci bot commented Sep 23, 2025

@ShazaAldawamneh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 8e0ef94 link false /test okd-scos-e2e-aws-ovn
ci/prow/minor-e2e-upgrade-minor 8e0ef94 link true /test minor-e2e-upgrade-minor
ci/prow/lint 8e0ef94 link true /test lint
ci/prow/integration 8e0ef94 link true /test integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants