Skip to content

Conversation

barbacbd
Copy link
Contributor

** The GCP endpoints for oauth and sts should not be overridden using the Private Service Connect. While these appear to be services just like the others (ex compute) they are not to be overridden as per google. Remove the option to override these endpoints.

** The GCP endpoints for oauth and sts should not be overridden using the Private Service Connect.
While these appear to be services just like the others (ex compute) they are not to be
overridden as per google. Remove the option to override these endpoints.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 22, 2025

@barbacbd: This pull request references CORS-4221 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

** The GCP endpoints for oauth and sts should not be overridden using the Private Service Connect. While these appear to be services just like the others (ex compute) they are not to be overridden as per google. Remove the option to override these endpoints.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Sep 22, 2025

Hello @barbacbd! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 22, 2025
@openshift-ci openshift-ci bot requested review from jkyros and JoelSpeed September 22, 2025 12:04
@JoelSpeed
Copy link
Contributor

This API is only available in tech preview. While normally removing an enum value is a breaking change, for tech preview we are able to make this change since we don't support upgrades

/lgtm
/verified bypass

This won't need verification

/override ci/prow/verify-crd-schema

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 22, 2025
@openshift-ci-robot
Copy link

@JoelSpeed: The verified label has been added.

In response to this:

This API is only available in tech preview. While normally removing an enum value is a breaking change, for tech preview we are able to make this change since we don't support upgrades

/lgtm
/verified bypass

This won't need verification

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2025
@openshift-ci-robot
Copy link

/test remaining-required

Scheduling tests matching the pipeline_run_if_changed parameter:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

Copy link
Contributor

openshift-ci bot commented Sep 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2025
Copy link
Contributor

openshift-ci bot commented Sep 22, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to this:

This API is only available in tech preview. While normally removing an enum value is a breaking change, for tech preview we are able to make this change since we don't support upgrades

/lgtm
/verified bypass

This won't need verification

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 04f99ea and 2 for PR HEAD ccf8770 in total

@JoelSpeed
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8a46f74 and 1 for PR HEAD ccf8770 in total

@barbacbd
Copy link
Contributor Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Sep 23, 2025

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn ccf8770 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-serial-2of2 ccf8770 link true /test e2e-aws-serial-2of2
ci/prow/e2e-aws-serial-1of2 ccf8770 link true /test e2e-aws-serial-1of2
ci/prow/e2e-aws-serial-techpreview-2of2 ccf8770 link true /test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-upgrade-out-of-change ccf8770 link true /test e2e-upgrade-out-of-change
ci/prow/e2e-aws-serial-techpreview-1of2 ccf8770 link true /test e2e-aws-serial-techpreview-1of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants