-
Notifications
You must be signed in to change notification settings - Fork 244
[WIP] SDN-3901: CNO 4.14 kubernetes 1.27 #1806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] SDN-3901: CNO 4.14 kubernetes 1.27 #1806
Conversation
@flavio-fernandes: This pull request references SDN-3901 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flavio-fernandes The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
76ca858
to
bda5df2
Compare
bda5df2
to
1292621
Compare
I'm in a pickle. If I try building after upgrading to 1.27 I hit the following failure:
I can see that this particular issue has been addressed here: However, by pulling in that fix, I break sigs.k8s.io/cluster-api as follows:
After upgrading
|
With @martinkennelly's help, we identified kubernetes-sigs/cluster-api#8007 for capi, where the |
1292621
to
f387f23
Compare
Well, one step fwd, and two steps... sideways. ;) This is where I'm stuck now:
|
go mod edit -go=1.20 removed k8s.io/apimachinery from replace section changed k8s.io/client-go to v0.27.2 in replace section added k8s.io/kube-openapi v0.0.0-20230515203736-54b630e78af5 in replace section to addresss issue with openAPIVersionedService.RegisterOpenAPIVersionedService compile go get -u k8s.io/api ; \ go get -u k8s.io/apiextensions-apiserver ; \ go mod tidy Signed-off-by: Flavio Fernandes <[email protected]>
Signed-off-by: Flavio Fernandes <[email protected]>
f387f23
to
edbb050
Compare
@flavio-fernandes: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Another step forward and another pitfall. In order to get past the issue with But now build fails in the following place (see below) and this is the version of k8s.io/client-go that I located the latest 1.27 version of k8s.io/client-go that uses ResourceEventHandlerRegistration without the missing method HasSynced and tried using it:
But could not get past mod tidy:
|
In order to get past
I tried using a replace for client-go:
|
Abandoning this PR. Will resume this work in #1826 |
Fix included in accepted release 4.14.0-0.nightly-2023-09-11-201102 |
Fix included in accepted release 4.14.0-0.nightly-2023-09-12-024050 |
Fix included in accepted release 4.14.0-0.nightly-2023-09-15-101929 |
Jira: https://issues.redhat.com/browse/SDN-3901