OTA-1585: test: Rename an existing test to comply with the OTE integration guide #1235
Conversation
Per the integration guide for OTE, each test must have a clearly defined owner (by using a [Jira:Component] tag) or an entry in the ci-test-mapping repository. Naming the owner as "Cluster Version Operator" with spaces, as this is the format used to distinguish our component in the mapping repository [1]. Renaming tests should not be done without a proper setup, as this can lose a test's history. However, this test was never executed, and it acts as a signal of the OTE integration. [1]: https://github.com/openshift-eng/ci-test-mapping/blob/b2ca5844ead12ede1cb72cae34321f3215beb6e3/pkg/components/clusterversionoperator/component.go#L14
openshift-ci-robot
added
the
jira/valid-reference
|
@DavidHurta: This pull request references OTA-1585 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
The verify-update job is working as expected. And it has reminded me that I have forgotten to update the tests metadata file. |
Such changes should not be done manually after the extension is integrated! Renaming tests should not be done without a proper setup, as this can lose a test's history. However, this test was never executed, and it acts as a signal of the OTE integration. Doing this change manually to not unnecessarily clutter the code with setting the original name of a test, which was never executed.
|
/hold WIP changes. |
openshift-ci
bot
added
the
do-not-merge/hold
|
@DavidHurta: This pull request references OTA-1585 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@DavidHurta: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidHurta, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified bypass Renaming a test. The test is not executed anywhere. |
openshift-ci-robot
added
the
verified
|
@DavidHurta: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit ad57230
into
openshift:main
Per the integration guide for OTE, each test must have a clearly defined owner (by using a
[Jira:Component]tag) or an entry in the ci-test-mapping repository. Naming the owner as"Cluster Version Operator"with spaces, as this is the format used to distinguish our component in the mapping repository [1].Renaming tests should not be done without a proper setup, as this can lose a test's history. However, this test was never executed, and it acts as a signal of the OTE integration.