pkg/payload/task: Handle MultipleErrors in SummaryForReason #576
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
The MultipleErrors reason landed in c2ac20f (status: Report the operators that have not yet deployed, 2019-04-09, openshift#158), but for some reason was left out of SummaryForReason. I'm adding it in this commit to get something more useful than: $ oc adm upgrade info: An upgrade is in progress. Unable to apply 4.8.0-0.ci-2021-05-26-172803: an unknown error has occurred: MultipleErrors when the Failing=True message is: Multiple errors are preventing progress: * Cluster operator machine-api is updating versions * Cluster operator openshift-apiserver is updating versions I'm not entirely clear on why these didn't fallback to the "unknown error" strings at the bottom of SummaryForReason, but they don't seem to have done so.
wking
force-pushed
the
MultipleErrors-progressing-message
branch
from
3dec0dd to
ca4ba8a
Compare
|
update job failed on $ curl -s https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-version-operator/576/pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-upgrade/1397703052256874496/build-log.txt | grep -o 'INFO:.*MultipleErrors' | uniq
INFO: cluster upgrade is Progressing: Unable to apply 4.8.0-0.ci.test-2021-05-26-235602-ci-op-2d6lcy28-initial: an unknown error has occurred: MultipleErrorsThe fact that we didn't see that on the A->B leg is promising, and the sort of thing this PR is trying to fix. /retest |
|
/retest |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The
MultipleErrorsreason landed in c2ac20f (#158), but for some reason was left out ofSummaryForReason. I'm adding it in this commit to get something more useful than:when the
Failing=Truemessage is:I'm not entirely clear on why these didn't fallback to the
unknown errorstrings at the bottom ofSummaryForReason, but they don't seem to have done so.