Skip to content

CONSOLE-3693: Upgrade to PFv5 versions #12983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Nov 21, 2023
Merged

CONSOLE-3693: Upgrade to PFv5 versions #12983

merged 30 commits into from
Nov 21, 2023

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Jul 6, 2023 •
edited by jcaianirh
Loading

Fixes: https://issues.redhat.com/browse/CONSOLE-3693
Updated all PF packages to their respective prerelease versions, which will be close to if not exact to what will be the finalized v5 packages within the next week or so.

Tested the frontend dev script, which now compiles:
image

and was able to load the application locally:
image

Also fixed all unit tests which broke due to PF selectors/re-arrangement of components:
image

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2023
@jpuzz0 jpuzz0 marked this pull request as draft July 6, 2023 18:52
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2023
@jpuzz0 jpuzz0 changed the title Draft: Upgrade to PFv5 prerelease versions Upgrade to PFv5 prerelease versions Jul 6, 2023
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 6, 2023
@openshift-ci openshift-ci bot requested review from abhinandan13jan and avivtur July 6, 2023 18:53
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2023

Hi @jpuzz0. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/network-attachment-definition Related to network-attachment-definition component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology kind/cypress Related to Cypress e2e integration testing labels Jul 6, 2023
@jpuzz0 jpuzz0 force-pushed the feat/pf-v5-upgrade branch from f7f0151 to 492e74b Compare July 6, 2023 19:08
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2023
@openshift openshift deleted a comment from openshift-ci bot Jul 6, 2023
jpuzz0 and others added 17 commits November 21, 2023 09:35
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
jcaianirh
jcaianirh approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
@jcaianirh
Copy link
Member

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 21, 2023
@rhamilto
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, jpuzz0, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 1ef3f9d into openshift:master Nov 21, 2023
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.15.0-202311220209.p0.g1ef3f9d.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

@sanketpathak sanketpathak mentioned this pull request Dec 8, 2023
Closed
@vojtechszocs vojtechszocs mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtechszocs vojtechszocs vojtechszocs left review comments

@rhamilto rhamilto rhamilto left review comments

@vikram-raj vikram-raj vikram-raj left review comments

@jcaianirh jcaianirh jcaianirh approved these changes

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

@avivtur avivtur Awaiting requested review from avivtur

@christianvogt christianvogt Awaiting requested review from christianvogt

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@yanpzhan yanpzhan

@jcaianirh jcaianirh

@opayne1 opayne1

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/network-attachment-definition Related to network-attachment-definition component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.