OCPBUGS-55689: UPSTREAM: 1303: Fix requeueing snapshot content after deletion error

[jsafrane]

Let syncContent() continue cleaning up VolumeSnapshotContent (i.e. remove its finalizers) after its snapshot has been deleted from the storage backend.

It will requeue on all errors.

Calling ctrl.updateContentInInformerCache() directly from deleteCSISnapshotOperation() does not requeue the snapshot content on error.

[openshift-ci-robot]

@jsafrane: This pull request references Jira Issue OCPBUGS-55689, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @nehaberry

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Let syncContent() continue cleaning up VolumeSnapshotContent (i.e. remove its finalizers) after its snapshot has been deleted from the storage backend.

It will requeue on all errors.

Calling ctrl.updateContentInInformerCache() directly from deleteCSISnapshotOperation() does not requeue the snapshot content on error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@jsafrane: This pull request references Jira Issue OCPBUGS-55689, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @nehaberry

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Let syncContent() continue cleaning up VolumeSnapshotContent (i.e. remove its finalizers) after its snapshot has been deleted from the storage backend.

It will requeue on all errors.

Calling ctrl.updateContentInInformerCache() directly from deleteCSISnapshotOperation() does not requeue the snapshot content on error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

/cherry-pick release-4.49

[openshift-cherrypick-robot]

@jsafrane: once the present PR merges, I will cherry-pick it on top of release-4.49 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.49

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jsafrane]

/cherry-pick release-4.19

[openshift-cherrypick-robot]

@jsafrane: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dobsonj]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1b2240d and 2 for PR HEAD e418a63 in total

[openshift-ci]

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jsafrane: Jira Issue OCPBUGS-55689: All pull requests linked via external trackers have merged:

• openshift/csi-external-snapshotter#180

Jira Issue OCPBUGS-55689 has been moved to the MODIFIED state.

In response to this:

Let syncContent() continue cleaning up VolumeSnapshotContent (i.e. remove its finalizers) after its snapshot has been deleted from the storage backend.

It will requeue on all errors.

Calling ctrl.updateContentInInformerCache() directly from deleteCSISnapshotOperation() does not requeue the snapshot content on error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@jsafrane: cannot checkout release-4.49: error checking out "release-4.49": exit status 1 error: pathspec 'release-4.49' did not match any file(s) known to git

In response to this:

/cherry-pick release-4.49

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@jsafrane: new pull request created: #182

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-csi-snapshot-controller
This PR has been included in build ose-csi-snapshot-controller-container-v4.20.0-202507080344.p0.gb5725af.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-csi-external-snapshotter
This PR has been included in build ose-csi-external-snapshotter-container-v4.20.0-202507080344.p0.gb5725af.assembly.stream.el9.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.20.0-0.nightly-2025-09-08-182033