Skip to content

Conversation

elmiko
Copy link

@elmiko elmiko commented Nov 14, 2023

This PR updates the 4.12 release branch to contain the backports from the upstream project. It is being proposed to fix a bug with CSINode objects creating a panic and crash within the autoscaler.

i created this PR with a process similar to #265

jayantjain93 and others added 30 commits January 25, 2023 17:28
…pick-cloud-based-uri-skuClient-1.25

baseURI for skuClient based on cloud cherry-pick kubernetes#5603
This follows go version update by kubernetes 1.25
…-pick-of-#5246-upstream-cluster-autoscaler-release-1.25

Automated cherry pick of kubernetes#5246: Don't break scale up with priority expander config
Added support for AWS inf2 instance types
Added support for the AWS Trainium instance types
Signed-off-by: tombokombo <[email protected]>
Signed-off-by: tombokombo <[email protected]>
…gs-1.25

Fix/asg resource tags for 1.25.x
…elease-1.25

Add preview EC2 instance type p4de.24xlarge
Signed-off-by: Maxim Rubchinsky <[email protected]>
Signed-off-by: Maxim Rubchinsky <[email protected]>
Signed-off-by: Maxim Rubchinsky <[email protected]>
Signed-off-by: Maxim Rubchinsky <[email protected]>
Signed-off-by: Maxim Rubchinsky <[email protected]>
…/sdk/auth/signers/signer_oidc.go

Co-authored-by: Huang Huang <[email protected]>
…/sdk/auth/signers/signer_oidc.go

Co-authored-by: Huang Huang <[email protected]>
Copy link

openshift-ci bot commented Nov 14, 2023

@elmiko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/git-history 231933e link false /test git-history

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elmiko
Copy link
Author

elmiko commented Nov 15, 2023

/test e2e-gcp-operator

@JoelSpeed
Copy link

/approve
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 16, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2023
Copy link

openshift-ci bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2023
@sunzhaohua2
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 17, 2023
@openshift-ci-robot
Copy link

@elmiko: This pull request references Jira Issue OCPBUGS-23274, which is invalid:

  • expected dependent Jira Issue OCPBUGS-23272 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This PR updates the 4.12 release branch to contain the backports from the upstream project. It is being proposed to fix a bug with CSINode objects creating a panic and crash within the autoscaler.

i created this PR with a process similar to #265

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sunzhaohua2
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 17, 2023
@sreber84
Copy link

/jira refresh

@openshift-ci-robot
Copy link

@sreber84: This pull request references Jira Issue OCPBUGS-23274, which is invalid:

  • expected dependent Jira Issue OCPBUGS-23272 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sreber84
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 22, 2023
@openshift-ci-robot
Copy link

@sreber84: This pull request references Jira Issue OCPBUGS-23274, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-23272 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-23272 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 November 22, 2023 13:15
@openshift-merge-bot openshift-merge-bot bot merged commit dd2b39d into openshift:release-4.12 Nov 22, 2023
@openshift-ci-robot
Copy link

@elmiko: Jira Issue OCPBUGS-23274: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23274 has been moved to the MODIFIED state.

In response to this:

This PR updates the 4.12 release branch to contain the backports from the upstream project. It is being proposed to fix a bug with CSINode objects creating a panic and crash within the autoscaler.

i created this PR with a process similar to #265

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build atomic-openshift-cluster-autoscaler-container-v4.12.0-202311221849.p0.gdd2b39d.assembly.stream for distgit atomic-openshift-cluster-autoscaler.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vertical-pod-autoscaler-container-v4.12.0-202311221849.p0.gdd2b39d.assembly.stream for distgit vertical-pod-autoscaler.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.