Skip to content

Conversation

elmiko
Copy link

@elmiko elmiko commented Feb 15, 2024

This change expands the snyk configuration file to cover more vendor folders and the cloud provider folders which are causing issues. It is safe to exclude other cloud providers because only the clusterapi provider is compiled into the binary for release.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 15, 2024
@openshift-ci-robot
Copy link

@elmiko: This pull request references Jira Issue OCPBUGS-28334, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This change expands the snyk configuration file to cover more vendor folders and the cloud provider folders which are causing issues. It is safe to exclude other cloud providers because only the clusterapi provider is compiled into the binary for release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 February 15, 2024 21:45
This change expands the snyk configuration file to cover more vendor
folders and the cloud provider folders which are causing issues. It is
safe to exclude other cloud providers because only the clusterapi
provider is compiled into the binary for release.
@RadekManak
Copy link

/lgtm
/assign JoelSpeed

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@JoelSpeed
Copy link

/approve
/lgtm

Copy link

openshift-ci bot commented Feb 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d832711 and 2 for PR HEAD dbd69d1 in total

@racheljpg
Copy link

/retest-required

@racheljpg
Copy link

/test e2e-aws

Copy link

openshift-ci bot commented Mar 1, 2024

@elmiko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9d29c92 into openshift:master Mar 1, 2024
@openshift-ci-robot
Copy link

@elmiko: Jira Issue OCPBUGS-28334: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28334 has been moved to the MODIFIED state.

In response to this:

This change expands the snyk configuration file to cover more vendor folders and the cloud provider folders which are causing issues. It is safe to exclude other cloud providers because only the clusterapi provider is compiled into the binary for release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build atomic-openshift-cluster-autoscaler-container-v4.16.0-202403011810.p0.g9d29c92.assembly.stream.el9 for distgit atomic-openshift-cluster-autoscaler.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants